Opened 13 years ago

Closed 13 years ago

#1875 closed defect (fixed)

MythWeb HD indicator problem

Reported by: anonymous Owned by: bjm
Priority: minor Milestone: unknown
Component: mythweb Version:
Severity: low Keywords:
Cc: Ticket locked: no

Description

In MythWeb, when a program has been scheduled to record it gets a yellow border. When the yellow border is active, the HD indicator dissapears. A show that appears to be HD, when scheduled to record loses the indicator - if you cancel the recording the HD indicator comes back.

Attachments (5)

scheduler_set_programflags.patch (1.1 KB) - added by david.asher@… 13 years ago.
make AddNewRecords? set programflags in ProgramInfo? structure
mythweb_decode_progflags.patch (2.2 KB) - added by david.asher@… 13 years ago.
make programs.php decode returned programflags
mythweb_decode_progflags.2.patch (3.5 KB) - added by david.asher@… 13 years ago.
decode progflags and copy data from DB for scheduled programs
mythweb_decode_progflags.3.patch (3.5 KB) - added by david.asher@… 13 years ago.
final version
scheduler_set_programflags.2.patch (991 bytes) - added by david.asher@… 13 years ago.
new version which applies cleanly

Download all attachments as: .zip

Change History (14)

comment:1 Changed 13 years ago by david.asher@…

There are 2 problems:

  1. the scheduler isn't setting programflags in the ProgramInfo? structure for in AddNewRecords?
  1. mythweb wasn't decoding programflags in programs.php.

the 2 attached patches fix the problem.

Changed 13 years ago by david.asher@…

make AddNewRecords? set programflags in ProgramInfo? structure

Changed 13 years ago by david.asher@…

make programs.php decode returned programflags

comment:2 Changed 13 years ago by David Asher <david.asher@…>

Wait, hang on. the scehduler patch still doesn't get the rating. I'll post an updated scheduler patch in a little bit.

Changed 13 years ago by david.asher@…

decode progflags and copy data from DB for scheduled programs

comment:3 Changed 13 years ago by anonymous

Ok, changing the scheduler didn't make sense because everything that wasn't sent via the myth protocol would have to be added. Instead the new patch copies the info from the DB (since its already fetched all the information) into the Program object held in Scheduled_Recordings. The progflags changes is still needed for HDTV, CC, and Stereo flags since the info is already transmitted, so I figured it might as well be used.

So, the scheduler_set_programflags.patch and mythweb_decode_progflags.2.patch are the two patches which need to be applied.

The two patches appear to fix all changes in displayed info between scheduled and non-scheduled items, EXCEPT the rating. For some reason this line in the mythweb patch:

$program->rating = $data['rating'];

DOESN'T work. I don't get it. All the other copies work. In fact, if I copy $data['rating'] onto $program->subtitle instead sure enough the subtitle gets overwritten with the rating. I don't know what I'm missing. It doesn't even work as: $program->rating = "foobar"; If you see why please fix it.

comment:4 Changed 13 years ago by david.asher@…

Ok, I figured out my mistake. The rating field was being set, but the description is precalculated.

Attached patch fixes this. I also changed the functionality to merge Program objects so any new fields will get updated without having to remember to do the copy.

Again, the only 2 patches needed are the scheduler patch and the latest mythweb_decode_progflags patch.

Changed 13 years ago by david.asher@…

final version

comment:5 Changed 13 years ago by xris

Owner: changed from xris to Isaac Richards

mythweb patch applied in [10441] -- reassigning to ijr so he can pass off the rest of this to someone who knows about the scheduler stuff (patch no longer cleanly applies, either)

Changed 13 years ago by david.asher@…

new version which applies cleanly

comment:6 Changed 13 years ago by david.asher@…

oops, hadn't checked this one in a while. i updated the scheduler_set_programflags patch to apply cleanly with svn head.

comment:7 Changed 13 years ago by Isaac Richards

Owner: changed from Isaac Richards to bjm

Bruce, is the scheduler patch ok?

comment:8 Changed 13 years ago by bjm

Yeah, it's inert. Cosmetically I'd change the order to group the flag fields together but that can be done in later cleanup.

comment:9 Changed 13 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [10542]) Backend part of #1875. Adds some program flags (hdtv, stereo, cc) to the scheduler.

Closes #1875.

Note: See TracTickets for help on using tickets.