Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2101 closed patch (fixed)

Fix RuntableMonitorSR

Reported by: Janne <janne-mythtv@…> Owned by: danielk
Priority: minor Milestone: 0.20
Component: dvb Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The first attached patch fixes DVBSignalMonitor::AddPIDFilters to set the filter and mask parameters correctly for ATSC and EIT PIDs if we use the sectionreader interface.

The second patch removes the now obsolte TS table monitor.

The first patch should go in before 0.20 since it fixes EIT and ATSC for certain USB1.1 devices. The second patch should maybe go in after 0.20. Though I haven't seen differences in the last three days. It doesn't solve the bogus events in #2094. So I'm quite confident that the pes packet assembler is now correct.

Attachments (2)

fix_RunTableMonitorSR.diff (1.8 KB) - added by Janne <janne-mythtv@…> 13 years ago.
remove_RunTableMonitorTS.diff (11.3 KB) - added by Janne <janne-mythtv@…> 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Janne <janne-mythtv@…>

Attachment: fix_RunTableMonitorSR.diff added

Changed 13 years ago by Janne <janne-mythtv@…>

comment:1 Changed 13 years ago by danielk

Milestone: 0.20
Version: head

comment:2 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10651]) Fixes #2101. Allow EIT data to be collected when the section reader is in use by the DVB signal monitor.

I'm not going to apply the other patch to use the section reader exclusively. The section reader code can not fully support both ATSC and DVB without being made significantly more complicated, and does not support "tuned" DVB channel scanning. It also does not work with some of the DVB-S and DVB-C broadcasters which improperly label their NIT and SDT tables as "other NIT" and "other SDT" tables.

The section reader as written is a functionally limited fallback for problematic USB devices, extending it to be fully functional would need to be a 0.21 project.

comment:3 Changed 13 years ago by danielk

(In [10655]) Refs #2101. Apply most of Janne's supplimentary patch which refines the table filtering masks.

I didn't add the CRC check flag. Some cards with CAM modules rewrite tuning tables without recalculating the CRC...

Note: See TracTickets for help on using tickets.