Opened 14 years ago

Closed 14 years ago

#2256 closed patch (fixed)

show metadata banner on fullscreen visualisers

Reported by: myth@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When showing fullscreen visualisers, display a banner at the bottom of the screen for 8 seconds when the track changes. The patch also includes a new visualiser by the name of Squares.

playbackbox

  • add a timer to playback box to disable the fullscreen banner fater 8 seconds
  • show/remove banner
  • show banner when INFO is pressed in fullscreen visualiser instead of the metadata editor.

mainvisual

  • fixes some indentation
  • add a drawWarning to VisualBase?, which just writes some text in the center of the visualiser (used by Spectrum and AlbumArt?). It correctly handles newlines in the message.
  • add a addInformation call to MainVisual?, which renders a pixmap containing the given string into a blue box which is added on top of the visualisers pixmap.
  • register SquaresFactory?.

visualiser:

  • make some methods in Spectrum virtual so it could be reused for Squares
  • changed albumart to update only at 1 fps, and cache the image (this is mostly because some other changes for the shoutcast streamer are more intrusive) and also always rerender the pixmap, since the MainVisual? needs to rerender the banner on top of it.
  • Added a visualiser called Squares. It's two rows of 16 rectangles that change color like the Spectrum visualiser.

Attachments (2)

mbanner.patch (19.4 KB) - added by myth@… 14 years ago.
patch that adds banner and new visualiser
fix-sdl-visuals.patch (5.2 KB) - added by babysimon 14 years ago.
Uses child widget

Download all attachments as: .zip

Change History (8)

Changed 14 years ago by myth@…

Attachment: mbanner.patch added

patch that adds banner and new visualiser

comment:1 Changed 14 years ago by anonymous

Version: head

comment:2 Changed 14 years ago by anonymous

The change in globalsettings.cpp needs an extra space between "Squares" and "and".

comment:3 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [11057]) Display a banner & add a new vis type from eskil.

Not exactly a bugfix, but code's clean and shouldn't have any undesired side-effects.

Closes #2256.

comment:4 Changed 14 years ago by Isaac Richards

Noticed that this only works for plugins that draw using Qt. Could possibly open up a new child widget instead, and write text to that instead of the main plugin window. Should get things working for the other vis types.

comment:5 Changed 14 years ago by mythtv at babysimon co uk

Resolution: fixed
Status: closedreopened

This patch does exactly that.

Changed 14 years ago by babysimon

Attachment: fix-sdl-visuals.patch added

Uses child widget

comment:6 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: reopenedclosed

(In [11092]) Patch to make the info banner work on non-Qt visuals. Closes #2256.

Note: See TracTickets for help on using tickets.