Opened 14 years ago
Closed 14 years ago
Last modified 13 years ago
#2316 closed defect (fixed)
channels.conf import adds unscanned channels
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythtv | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Channels imported from a channels.conf always start at channel id 501, even if those ids are already taken.
When the cable provider adds new channels, it makes sense to import a minimal channels.conf, just with these channels. They should be added at the end.
So, the importer should start with max(channel id) + 1.
Change History (6)
comment:1 Changed 14 years ago by
| Owner: | changed from Isaac Richards to danielk |
|---|---|
| Summary: | Importing channels.conf always starts at 501 → channels.conf import adds unscanned channels |
| Version: | 0.19 → head |
comment:2 Changed 14 years ago by
In my case, it was not unwanted channels. It was new channels, but MythTV added them on channel numbers, that were already taken.
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [11682]) Fixes #2316. Adds checks of dvb-utils imported channels before adding them to the DB.
This also moves the dvb-utils scanner output parsers from dvbtypes.{h,cpp} to dtvconfparserhelpers.{h,cpp} so that dvb-utils channel maps can be imported for non-DVB cards like the HDHomeRun without compiling MythTV with DVB support.
This uses the list of channels generated by the dvb-utils channels.conf parser to seed the internal channel scanner. It then scan the inserted transports like it does normally, except that before inserting channels it checks the parser output and uses it's name for the channel rather than whatever the scanner picked up. Any channels we find on the same transport as a channels.conf channel are reported but not added to the database.
This also avoids use of the dvb-utils channels.conf parser's DB manipulation routines which were causing the problems reported in #2316, notably channels inserted with the same channel id as an existing channel.
MythTV should verify all channel.conf channels before adding them to the DB, this would solve this and the no EIT on channel.conf imported channels problem.