Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#2316 closed defect (fixed)

channels.conf import adds unscanned channels

Reported by: thomas@… Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Channels imported from a channels.conf always start at channel id 501, even if those ids are already taken.

When the cable provider adds new channels, it makes sense to import a minimal channels.conf, just with these channels. They should be added at the end.

So, the importer should start with max(channel id) + 1.

Change History (6)

comment:1 Changed 14 years ago by danielk

Owner: changed from Isaac Richards to danielk
Summary: Importing channels.conf always starts at 501channels.conf import adds unscanned channels
Version: 0.19head

MythTV should verify all channel.conf channels before adding them to the DB, this would solve this and the no EIT on channel.conf imported channels problem.

comment:2 Changed 14 years ago by thomas@…

In my case, it was not unwanted channels. It was new channels, but MythTV added them on channel numbers, that were already taken.

comment:3 Changed 13 years ago by danielk

(In [11681]) Refs #2316. Refs #2533. Cleanup of the transient mythtv settings.

Some were defined in dbsettings.cpp and some in settings.h. Some were duplicates. This moves them to settings.h and standardizes the naming.

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [11682]) Fixes #2316. Adds checks of dvb-utils imported channels before adding them to the DB.

This also moves the dvb-utils scanner output parsers from dvbtypes.{h,cpp} to dtvconfparserhelpers.{h,cpp} so that dvb-utils channel maps can be imported for non-DVB cards like the HDHomeRun without compiling MythTV with DVB support.

This uses the list of channels generated by the dvb-utils channels.conf parser to seed the internal channel scanner. It then scan the inserted transports like it does normally, except that before inserting channels it checks the parser output and uses it's name for the channel rather than whatever the scanner picked up. Any channels we find on the same transport as a channels.conf channel are reported but not added to the database.

This also avoids use of the dvb-utils channels.conf parser's DB manipulation routines which were causing the problems reported in #2316, notably channels inserted with the same channel id as an existing channel.

comment:5 Changed 13 years ago by danielk

(In [11683]) Refs #2316. Fixes some copy-n-paste brokeness in [11682]. I compiled the test with the wrong flags :/

comment:6 Changed 13 years ago by Jarod Wilson

(In [13237]) - Backport of trunk changesets [11681], [11682] and [11683]

to make digital cable channel scanning truly actually work (successfully tested by myself w/an AirStar? HD-5000 and HDHomeRun, and by Janne w/DVB-T and C)

Note: See TracTickets for help on using tickets.