Opened 13 years ago

Closed 12 years ago

Last modified 11 years ago

#2595 closed enhancement (fixed)

Refactor MythMusic Visualisations

Reported by: mythtv@… Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch refactors the visualisation selection code within MythMusic. It depends on the patches attached to Ticket #2594.

The new approach decouples the linkage between visualisations and the mainvisual.cpp source file. This means that this file no longer requires modification in order to add a new visualisation.

This patch also modifies the way MythMusic visualisations are selected. By using the new multi-select functionality contained in the patches attached to Ticket #2594. Visualisations are now enumerated and a complete list of available visualisations are presented in the configuration page.

The order in which the visualisations are selected is preserved in the player (i.e. first one selected will always be first one used) unless the “Randomise” feature is enabled.

Attachments (3)

visualisation_refactor.patch (31.2 KB) - added by mythtv@… 13 years ago.
visualisation_refactor_r12452.patch (31.3 KB) - added by mythtv@… 12 years ago.
Patch refresh against head revision 12452
visualisation_refactor_r12786.patch (31.5 KB) - added by mythtv@… 12 years ago.
Patch refresh against head revision 12786

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by mythtv@…

comment:1 Changed 12 years ago by jpoet@…

Broken by changeset 12443.

Changed 12 years ago by mythtv@…

Patch refresh against head revision 12452

Changed 12 years ago by mythtv@…

Patch refresh against head revision 12786

comment:2 Changed 12 years ago by paulh

There's a minor problem with this in that when you use MythMusic for the first time after applying this patch you get the error message

SelectSetting(VisualMode)::setValue(MonoScope,StereoScope,BumpScope,Goom,Synaesthesia,Squares,Gears,AlbumArt): invalid value

and when you try to switch to a visualizer you just get a black screen that's because the old visualMode setting is in the wrong format.

I think it would be better to either set it to a good default value or better still convert the old setting into the new format?

comment:3 Changed 12 years ago by paulh

Milestone: unknown0.21
Owner: changed from Isaac Richards to paulh

comment:4 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [13268]) Refactor MythMusic's Visualisations. Based on the original patch on ticket #2595 with some changes to make it easier to add the new LibVisual? visualisation.

In addition to the changes stated on the ticket it also make it possible for a visualiser to support more than one effect. Non of the existing visualisers do that but it will make it easier to add a new one based on LibVisual? which can have many plugins each providing a new effect/visual.

I also added a new dialog to edit the allowed visualisations list. The order you place visualisations in the selected list is the order they will be used in the player unless you have the 'Randomise' feature turned on.

You probably need to do a distclean of mythmusic so some of the changes to signal/slots get picked up properly by qmake/moc.

Closes #2595.

comment:5 Changed 11 years ago by danielk

(In [17619]) Refs #2595. Renames dvbconfparser.{h,cpp} to match name of class in file.

comment:6 Changed 11 years ago by danielk

(In [17620]) Refs #2595. Merges some DTVConfParser fixes over from channel scanner branch.

Note: See TracTickets for help on using tickets.