Opened 13 years ago

Closed 13 years ago

#2596 closed patch (fixed)

MythTV improperly interprets hide_guide

Reported by: mrussotto@… Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: 0.20
Severity: low Keywords:
Cc: Ticket locked: no

Description

The bit in the Virtual Channel Table called "hide_guide" is used by MythTV to ignore program guide information in the ATSC stream. This isn't correct; the "hide_guide" bit should be used only to conceal program information when the "hidden" bit is also set. If the hidden bit is not set, hide_guide should be ignored. See ATSC standard A/65C

Unfortunately a number of the Philadelphia channels inexplicably set this bit.

Attachments (2)

2596-v1.patch (957 bytes) - added by danielk 13 years ago.
fix for use_on_air_guide bit in initial scan
2596-v2.patch (1.5 KB) - added by anonymous 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by danielk

Owner: changed from Isaac Richards to danielk
Severity: mediumlow

Can you find the page of 65C that specifies this?

comment:2 Changed 13 years ago by mrussotto@…

Page 34. (Adobe Reader calls it Page 35, but the bottom of the page is marked 34)

Changed 13 years ago by danielk

Attachment: 2596-v1.patch added

fix for use_on_air_guide bit in initial scan

comment:3 Changed 13 years ago by danielk

Milestone: unknown0.21
Type: defectpatch

mrussotto, can you test the attached patch?

You will need to delete your existing channels and rescan, but it should properly set the use_on_air_guide bit.

I believe the Philly channels are doing the right thing, in general MPEG and ATSC say that undefined bits should be set.

Changed 13 years ago by anonymous

Attachment: 2596-v2.patch added

comment:4 Changed 13 years ago by mrussotto@…

That got the use_on_air_guide bit set but didn't quite do it. I've attached a patch which fixes mpeg/atscstreamdata.cpp as well.

comment:5 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [11628]) Fixes #2596. Properly interpret hide_guide property in ATSC PSIP.

Note: See TracTickets for help on using tickets.