Opened 13 years ago

Closed 13 years ago

#2838 closed patch (fixed)

Allow use of Arbitrary commands for mythwelcome setwakeuptime

Reported by: devel@… Owned by: paulh
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords: mythwelcome mythshutdown
Cc: Ticket locked: no


This patch modifies the configuration for MythShutdownNvramCmd? to allow for any command to be used, rather than hardcoding the parameters "--settime %1". Hence, also adds WakeTimeFormat? config box.

Attachments (2)

mythwelcome-wakeupcmd.diff (2.0 KB) - added by devel@… 13 years ago.
Mythwelcome config page changes
mythshutdown-wakeupcmd.diff (1.1 KB) - added by devel@… 13 years ago.
Mythshutdown shutdown command logic

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by devel@…

Attachment: mythwelcome-wakeupcmd.diff added

Mythwelcome config page changes

Changed 13 years ago by devel@…

Attachment: mythshutdown-wakeupcmd.diff added

Mythshutdown shutdown command logic

comment:1 Changed 13 years ago by paulh

Owner: changed from Isaac Richards to paulh

comment:2 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [12374]) Close #2838 by applying the patch.

Allows the time format sent to the MythShutdownNvramCmd? to be specified rather than using a hardcoded format. Should allow for using commands other than nvram-wakup to set the wakeup time in the BIOS.

I added a DB update to change the existing MythShutdownNvramCmd? settings to use the new format so everything should work just the way it was before this patch. Also updated the README.

comment:3 Changed 13 years ago by maillists@…

Resolution: fixed
Status: closedreopened

This fix has caused me problems. What it does is make the time format used by the backend when scheduling (ast argument to mythshutdown --setwakeup) the same as that used for the command to set the wake-up time (called from mythshutdown -q; I'm using nvram-wakeup) and, in my case at least, both require a different format.

The same entry in the settings table (WakeupTimeFormat?) is used for both!....

I've got things working on my system by changing the setting used by mythshutdown, and adding the approprate row in the settings table.

comment:4 Changed 13 years ago by paulh

Resolution: fixed
Status: reopenedclosed

(In [12583]) Rename the time format setting that is passed to the MythShutdownNvramCmd? to avoid a clash with a similar setting used by the backend to set the next wakeup time. If you don't use the default time_t format you will have to change the setting on MythWelcome?'s settings page.

Fixes #2838.

Note: See TracTickets for help on using tickets.