Opened 13 years ago

Closed 13 years ago

Last modified 5 years ago

#2932 closed defect (fixed)

mythtv-setup tries to open non-existend theme "Standard"

Reported by: tino.keitel+mythtv@… Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When I run mythtv-setup, it tries to open a theme called "Standard", which doesn't exist, and falls back to GANT. After this, mythfrontend also uses GANT and I have to reset it to the desired theme.

I created a symlink called "Standard" as a workaround.

$ echo "select * from settings;" | mysql -u mythtv -p mythconverg | grep "Theme.*Iulius"
Enter password: 
Theme	Iulius	dose

$ strace -f mythtv-setup 2>&1 | grep Standard
access("/home/scorpion/.mythtv/themes/Standard", F_OK) = -1 ENOENT (No such file or directory)
access("/usr/share/mythtv/themes/Standard", F_OK) = 0

I found the culprit in my database:

$ echo "select * from settings;" | mysql -u mythtv -p mythconverg | grep "Standard"
Enter password: 
MenuTheme	Standard	dose

Somehow the setup uses MenuTheme? instead of Theme.

Attachments (1)

menutheme_fix.diff (4.4 KB) - added by stuartm 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by stuartm

Milestone: unknown0.21
Owner: changed from Isaac Richards to stuartm
Status: newassigned

We're translating MenuTheme? when we shouldn't be (Standard is the translation of default in several countries).

comment:2 Changed 13 years ago by stuartm

Main problem is the assumption in MythContext::FindThemeDir? that we're dealing with 'Theme' when we may be handling 'MenuTheme?'.

Changed 13 years ago by stuartm

Attachment: menutheme_fix.diff added

comment:3 Changed 13 years ago by stuartm

Could you please try the attached patch.

comment:4 Changed 13 years ago by anonymous

The patch fixes the broken behaviour for me:

$ echo "select * from settings;" | mysql -u mythtv -p mythconverg | grep -i MenuTheme
Enter password: 
MenuTheme	default	dose

mythtv-setup now uses the correct menu theme and doesn't fall back to GANT anymore.

comment:5 Changed 13 years ago by stuartm

Resolution: fixed
Status: assignedclosed

(In [12557]) Fixes #2932

Split MythContext::FindThemeDir? into MythContext::FindMenuThemeDir?. In the event that the menu theme is missing we fall back to the 'default' menu theme.

In the appearance settings we no longer save the translation of 'default' to the database for MenuTheme?.

Note: See TracTickets for help on using tickets.