mythtv-setup tries to open non-existend theme "Standard"

[tino.keitel+mythtv@…]

When I run mythtv-setup, it tries to open a theme called "Standard", which doesn't exist, and falls back to GANT. After this, mythfrontend also uses GANT and I have to reset it to the desired theme.

I created a symlink called "Standard" as a workaround.

$ echo "select * from settings;" | mysql -u mythtv -p mythconverg | grep "Theme.*Iulius"
Enter password: 
Theme	Iulius	dose

$ strace -f mythtv-setup 2>&1 | grep Standard
access("/home/scorpion/.mythtv/themes/Standard", F_OK) = -1 ENOENT (No such file or directory)
access("/usr/share/mythtv/themes/Standard", F_OK) = 0

I found the culprit in my database:

$ echo "select * from settings;" | mysql -u mythtv -p mythconverg | grep "Standard"
Enter password: 
MenuTheme	Standard	dose

Somehow the setup uses MenuTheme? instead of Theme.

[stuartm]

We're translating MenuTheme? when we shouldn't be (Standard is the translation of default in several countries).

[stuartm]

Main problem is the assumption in MythContext::FindThemeDir? that we're dealing with 'Theme' when we may be handling 'MenuTheme?'.

[stuartm]

Could you please try the attached patch.

[anonymous]

The patch fixes the broken behaviour for me:

$ echo "select * from settings;" | mysql -u mythtv -p mythconverg | grep -i MenuTheme
Enter password: 
MenuTheme	default	dose

mythtv-setup now uses the correct menu theme and doesn't fall back to GANT anymore.

[stuartm]

(In [12557]) Fixes #2932

Split MythContext::FindThemeDir? into MythContext::FindMenuThemeDir?. In the event that the menu theme is missing we fall back to the 'default' menu theme.

In the appearance settings we no longer save the translation of 'default' to the database for MenuTheme?.