Opened 17 years ago
Closed 17 years ago
#3744 closed defect (fixed)
Fix broken image references in music-ui.xml
Reported by: | Owned by: | Justin Hornsby | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | theme | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
I suspect the recent cleanup broke this, but not sure as I don't usually use any of these themes.
This problem breaks the editmetadata screens, maybe others as well.
The affected image references are:
mm_checked.png mm_unchecked.png mm_checked_high.png mm_unchecked_high.png mm_blankbutton_on.png mm_blankbutton_off.png mm_blankbutton_pushed.png mm_leftright_on.png mm_leftright_off.png mm_leftright_pushed.png
Patches attached fix the music-ui.xml files, although maybe it was intended that the mm_* files were created instead. ie svn copy blankbutton_on.png mm_blankbutton_on.png, although default-wide/music-ui.xml refers to blankbutton_on.png etc.
Roo
Attachments (2)
Change History (6)
Changed 17 years ago by
Attachment: | mythtv_music-ui.xml.diff added |
---|
Changed 17 years ago by
Attachment: | myththemes_music-ui.xml.diff added |
---|
comment:1 Changed 17 years ago by
comment:2 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 17 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I have just done some testing on a clean install of trunk r14012. There are still a couple of probs, below is a summary:
Missing checkbox, button images (caused by removed mm_* images):
- Titivillus
- Minimalist-wide
Metadata editor screen ("i" from playlist) missing "Track Info" & "Album Art" buttons
- Titvillus
- Blue
- G.A.N.T.
- Minimalist-wide
The "myththemes_music-ui.xml.diff" will address the checkbox images etc in Titivillus and Minimalist-wide themes.
I will provide a patch for the buttons unless someone beats me to it :)
* Thinking a bit more about this, I suspect the problem has gone unnoticed as people would still have the mm_* images installed from prior to [12897], when they were removed. I was testing from a clean install, with a clean /usr/local/
Not a big deal in the grand scheme of things :)
comment:4 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Closing this. Will fix the 'missing' theme elements very soon - they should by rights have been on a separate ticket in any case.
see changesets [12897], [12893] and [12903]