Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3793 closed defect (fixed)

mythfilldatabase doesn't pass graboptions to xmltv grabber

Reported by: anonymous Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythfilldatabase Version: head
Severity: low Keywords: graboptions
Cc: Ticket locked: no

Description

The graboptions are not used at all in the filldata.cpp file. I think adding one line will be sufficient (at least it works for me)

command += graboptions

but since I'm not familiar with the code, I am hoping someone else will confirm this and possibly make the fix.

Change History (3)

comment:1 Changed 12 years ago by stuartm

Milestone: unknown0.21
Version: unknownhead

You are correct about the fix and I'll commit it shortly.

In the interests of improving mythfilldatabase and the xmltv grabbers, which grabber are you using and what options do you want to pass to the grabber?

comment:2 Changed 12 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [14149]) Fixes #3793

Append graboptions to the xmltv grabber command.

Added warning to the help text about this option which should only be used in special circumstances. Mythfilldatabase will already append all the arguments necessary for normal usage of the grabber. It should not require any special arguments except those declared through --capabilities and --preferredmethod.

comment:3 in reply to:  1 Changed 12 years ago by anonymous

Replying to stuartm:

You are correct about the fix and I'll commit it shortly.

In the interests of improving mythfilldatabase and the xmltv grabbers, which grabber are you using and what options do you want to pass to the grabber?

Hi Stuart,

I'm using a non-standard dutch grabber 'tv_grab_nl_py' (http://graphics.tudelft.nl/~paul/grabber/) and although it does work without the graboptions parameter I wanted to pass a parameter "--desc-length" parameter, which was recently added (in a patch on the mailinglist) I don't think there is any need to change the mythfilldatabase functionality, it's just a special (and possibly temporary) parameter I want to pass, when I noticed this issue. Anyway, thanks for your fix, and fast reply

Note: See TracTickets for help on using tickets.