Segfault adding record override after viewing program details

[anonymous]

Sequence:

• go to "Upcoming Recordings" page
• view program details for an upcoming recording, then go back (hit "u", "ESC")
• view recording dialog (hit "space")
• add override (select "Don't Record" or "Add Override")

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1209124592 (LWP 23163)]
0x004e1532 in ScheduledRecording::makeOverride (this=0x89c2de0) at scheduledrecording.cpp:941
941	    parentid->setValue(m_pginfo->recordid);

Backtrace will follow. I believe the problem is that ProgramInfo::showDetails initializes "record" using loadByID, which does not set "record->m_pginfo". Then, when ApplyRecordStateChange calls GetProgramRecordingStatus, "record" is left unchanged.

This is with r14355 but the affected files seem to be unchanged in HEAD.

The attached patch seems to fix it.

[gtgj@…]

backtrace of segfault with program details -> add override

[gtgj@…]

patch for segfault

[gtgj@…]

(Sorry, reporter field got reset to "anonymous". It should be me. Also, formatting is messed up. Here is the sequence for reproducing the segfault:)

Sequence:

• go to "Upcoming Recordings" page
  
• view program details for an upcoming recording, then go back (hit "u", "ESC")
  
• view recording dialog (hit "space")
  
• add override (select "Don't Record" or "Add Override")

[paulh]

This looks like a duplicate of #3321