Opened 14 years ago

Closed 14 years ago

#402 closed patch (fixed)

mythweb/mythvideo assumes category IDs are sequential

Reported by: Adam Di Carlo <aph@…> Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Minor defect in the presentation of the category drop-down in video.php. The code assumes it can count up the category ids sequentially, but its not necessary true:

mysql> SELECT * FROM videocategory;
+-------+---------------------+
| intid | category            |
+-------+---------------------+
|     5 | TV                  |
|     1 | Movie               |
|     2 | Anime series        |
|     3 | Anime OVA           |
|     4 | Anime movie         |
|    15 | Anime special/extra |
|    16 | music video         |
+-------+---------------------+

The attached simple patch against the 0.18 branch fixes this problem.

Attachments (2)

category_list_ids.diff (518 bytes) - added by Adam Di Carlo <aph@…> 14 years ago.
category_list_ids.2.diff (1.3 KB) - added by Adam Di Carlo <aph@…> 14 years ago.
updated patch against 0.18 branch; includes the corresponding fix in video_edit.php

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by Adam Di Carlo <aph@…>

Attachment: category_list_ids.diff added

comment:1 Changed 14 years ago by Adam Di Carlo <aph@…>

Component: mythtvmythweb
Owner: changed from Isaac Richards to xris

Changed 14 years ago by Adam Di Carlo <aph@…>

Attachment: category_list_ids.2.diff added

updated patch against 0.18 branch; includes the corresponding fix in video_edit.php

comment:2 Changed 14 years ago by xris

Resolution: fixed
Status: newclosed

(In [7704]) apply patch to close #402

Note: See TracTickets for help on using tickets.