Opened 13 years ago

Closed 13 years ago

#4048 closed defect (fixed)

Blue theme has some mis-named files

Reported by: Tom Lichti <tom@…> Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no


A number of the widget images are misnamed in the Blue theme. I tried creating a patch, but am having difficulty with that. Here is a list of commands to fix it:

cd mythtv/themes/blue

svn mv mm_blankbutton_off.png mv_blankbutton_off.png svn mv mm_blankbutton_on.png mv_blankbutton_on.png svn mv mm_blankbutton_pushed.png mv_blankbutton_pushed.png svn mv mm_checked.png mv_checked.png svn mv mm_checked_high.png mv_checked_high.png svn mv mm_leftright_off.png mv_leftright_off.png svn mv mm_leftright_on.png mv_leftright_on.png svn mv mm_leftright_pushed.png mv_leftright_pushed.png svn mv mm_unchecked.png mv_unchecked.png svn mv mm_unchecked_high.png mv_unchecked_high.png svn mv mm_waiting.png mv_waiting.png

Change History (3)

comment:1 Changed 13 years ago by Nigel

Hi Tom. I think you will find that, if you rename those files, then MythMusic will not be able to find them. Check all the .xml files - music-ui.xml uses mm_*.png, and video-ui.xml uses mv_*.png.
I didn't pay a lot of attention to the recent theme rationalisation (e.g. the default and default-wide directories), but I suspect blue's version of those files should be named blankbutton_off.png, blankbutton_on.png et c., and the .xml files be edited to match.

comment:2 Changed 13 years ago by paulh

Milestone: unknown0.21
Owner: changed from Isaac Richards to paulh
Type: patchdefect

comment:3 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [14742]) Rename some of the images in the Blue theme to be more generic and also to have the same names as those in the default theme.

The advantage of using the same names as the default images is so that plugins that themers don't usually bother to theme like MythArchive? and MythZoneMinder? will automatically use the images from the theme rather than use the default images.

Fixes #4048.

Note: See TracTickets for help on using tickets.