Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4259 closed patch (fixed)

Hebrew language support : MythArchive

Reported by: ido_roseman@… Owned by: paulh
Priority: minor Milestone: 0.21
Component: mytharchive Version: head
Severity: medium Keywords: hebrew
Cc: Ticket locked: no

Description

the python text rendering does not have support for Right To Left scripts, so the DVD menus get mixed up. after the text is splited into lines, i added a call to twick each line of text so it will look ok. I use the pyfribidi module for the implementation (sorry for adding a dependency)

Attachments (2)

mythburn.py.diff (481 bytes) - added by ido_roseman@… 12 years ago.
patch for hebrew rendering in mythburn script
mythburn.2.diff (1.3 KB) - added by ido roseman <ido_roseman@…> 12 years ago.
support for RTL script with fallback where pyfribidi is missing

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by ido_roseman@…

Attachment: mythburn.py.diff added

patch for hebrew rendering in mythburn script

comment:1 Changed 12 years ago by paulh

Resolution: wontfix
Status: newclosed

You will have to find a way to make this optional before I will commit it. I don't think it is fair that everyone will have to install the pyfribidi module even though most people don't need it.

comment:2 Changed 12 years ago by ido roseman <ido_roseman@…>

Resolution: wontfix
Status: closednew

personally, i think adding yet another module is a small price to pay for mythtv to become a mature and universal software. but i accepted the challenge and found a way to make it optional. this is my first time writing python, so i hope it's OK. anyway, IT WORKS (and doesn't break if pyfribidi is missing).

Changed 12 years ago by ido roseman <ido_roseman@…>

Attachment: mythburn.2.diff added

support for RTL script with fallback where pyfribidi is missing

comment:3 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [15346]) Add optional support in MythArchive? for creating DVD menus for right to left languages. Requires pyfribidi python module to be installed for this to work.

Only tested to make sure it doesn't break anything if pyfribidi isn't installed.

Patch by Ido Roseman. Closes #4259.

comment:4 Changed 12 years ago by paulh

Milestone: unknown0.21
Version: unknownhead
Note: See TracTickets for help on using tickets.