Opened 12 years ago

Closed 8 years ago

#4412 closed Patch - Feature (Won't Fix)

remove Win32 dependancy on directX headers from DXSDK

Reported by: David Bussenschutt <davidbuzz@…> Owned by: robertm
Priority: minor Milestone: unknown
Component: Ports - Windows Version: Master Head
Severity: low Keywords: Win32
Cc: Ticket locked: no

Description

Opend this Trac so as we don't forget to look into this as some stage:

Buzz's initial suggestion:

  • regarding the DXSDK header files- my suggestion is that we just wack

the 3 needed header files,a README.txtexplaining whatit isand a LICENCE file into a zip file , and put it on a server somewhere. Given that .h files document the API in the rest of the software/sdk (which we don't need), I'd think that they fall under the "documentation" section of the EULA which says that: "4. DOCUMENTATION. Any person that has valid access to your computer or internal network may copy and use the documentation for your internal, reference purposes.". Which translated says to methat "any valid mythtv developer may use it for mythtv development purposes by accessing it from a mythtv related server (like trac or svn)". I am not a lawyer.

Andrei's response: We only need a handful of function declarations from dsound.h, I think the easiest thing to do might be to place these declarations in compat.h and get rid of this dependency altogether.

...

Another option is not to compile audiooutputdx at all - in its current state it's not usable anyway (I wrote and tested audiooutputwin and I am satisfied with the way it works).

Attachments (1)

4412-dsound.patch (4.1 KB) - added by Jeff Lu <jll544@…> 10 years ago.
Suggested approach: check for dsound.h in configure

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by David Bussenschutt (aka buzz) <davidbuzz@…>

in the Win32-packager.pl script, I have used an alternative source for the header files, which we could use in the wiki doco regarding this.... but the proper solution is still what Andrei suggested, so the ticket should stay open for now.

comment:2 Changed 12 years ago by Buzz <davidbuzz@…>

quick update: the win32-packager.pl actually does (and has for quite some time) what I initially suggested (ie the few needed .h files are just stored in a .zip file on a website, without the rest of the DXSDK, which isn't needed), but it'd still be nice to do andre's suggestion (using compat.h, and removing the need for these headers altogether.

comment:3 Changed 10 years ago by stuartm

Component: mythtvPorts - Windows
Status: newinfoneeded_new

Can this ticket be closed yet?

comment:4 Changed 10 years ago by anonymous

So long as we have directx code in mythtv ( despite being deprecated) , and we still have the following code block in the build script, then this ticket is here to remind us to come up with a better solution( ie get rid of the directx code from mythtv that uses dsound.h) : 643 # ( save bandwidth compare to the above full SDK where they came from: 644 [ archive => $sources.'DX9SDK_dsound_Include_subset.zip', 645 'fetch' => 'http://davidbuzz.googlepages.com/'. 646 'DX9SDK_dsound_Include_subset.zip', 647 comment => 'We download just the required Include files for DX9' ], 648 [ dir => $sources.'DX9SDK_dsound_Include_subset', 649 extract => $sources.'DX9SDK_dsound_Include_subset.zip' ], 650 [ filesame => [$mingw.'include/dsound.h',$sources. 651 "DX9SDK_dsound_Include_subset/dsound.h"], 652 copy => [=>] ], 653 [ filesame => [$mingw.'include/dinput.h',$sources. 654 "DX9SDK_dsound_Include_subset/dinput.h"], 655 copy => [=>] ], 656 [ filesame => [$mingw.'include/ddraw.h', $sources. 657 "DX9SDK_dsound_Include_subset/ddraw.h"], 658 copy => [=>] ], 659 [ filesame => [$mingw.'include/dsetup.h',$sources. 660 "DX9SDK_dsound_Include_subset/dsetup.h"], 661 copy => [=>] ], 662 ;

comment:5 Changed 10 years ago by robertm

Status: infoneeded_newnew

Changed 10 years ago by Jeff Lu <jll544@…>

Attachment: 4412-dsound.patch added

Suggested approach: check for dsound.h in configure

comment:6 Changed 9 years ago by danielk

Owner: changed from Isaac Richards to markk
Status: newassigned
Type: taskpatch

Mark K & Nigel have Windows computers, I'm assigning windows tickets semi-randomly to one of them.

comment:7 Changed 9 years ago by robertm

Owner: changed from markk to robertm

Is anyone using DX sound output that has a critical reason for needing it? It seems that standardizing on the better support audiooutputwin ("Windows:") method would be both more intuitive and better supported.

comment:8 Changed 9 years ago by robertm

Milestone: unknown0.25

comment:9 Changed 9 years ago by stuartm

Milestone: 0.25

Milestone 0.25 deleted

comment:10 Changed 8 years ago by beirdo

Milestone: 0.25unknown

comment:11 Changed 8 years ago by stuartm

Resolution: Won't Fix
Status: assignedclosed
Type: patchPatch - Feature
Version: headMaster Head

This is dead, a four year old ticket that no-one is wanting to work on. Close it rather than playing pass the parcel for another year.

Note: See TracTickets for help on using tickets.