Opened 14 years ago

Closed 14 years ago

#462 closed enhancement (fixed)

PiP aspect ratio improvement

Reported by: mark.kendall@… Owned by: danielk
Priority: trivial Milestone: 0.20
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The attached patch should ensure the aspect ratio of the PiP video source is respected. It calculates the pip height as a % of the main source (set at 26%, consistent with current code) and scales the width appropriately. A marginal increase in overhead per frame processed but it does dynamically adjust the pip size as the aspect ratio changes (quite common on certain UK dvb-t channels).

It also backs out changeset:7080 which is no longer required.

I've not touched videoout_ivtv (as I cannot test it) but see no reason why the changes should not work there too.

Attachments (3)

pipaspect.diff (2.3 KB) - added by anonymous 14 years ago.
PiPScreenShot.jpg (207.5 KB) - added by anonymous 14 years ago.
Screenshot with PiP in Top-Right corner.
mythfrontend.log (85.1 KB) - added by anonymous 14 years ago.
mythfrontend log with "playback"

Download all attachments as: .zip

Change History (15)

Changed 14 years ago by anonymous

Attachment: pipaspect.diff added

comment:1 Changed 14 years ago by danielk

Milestone: 0.19
Owner: changed from Isaac Richards to danielk
Status: newassigned

I'll have a look at this today.

comment:2 Changed 14 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [7473]) Closes #462.

I made some changes so as to not base the aspect ratio calculation off the aspect ratio of the main playing video, but instead base it directly off the screen dimensions. I think is a bit more safer and a bit more clear.

comment:3 Changed 14 years ago by anonymous

Resolution: fixed
Status: closedreopened

I have DVB images that 720x576 with a 16:9 aspect ratio. If you have aspect override off, on a 4:3 display you get the main video window with black bars top and bottom, which is fine. But the PiP window is stretched horizontally.

changeset:7560 has no effect on this.

comment:4 Changed 14 years ago by danielk

"But the PiP window is stretched horizontally."

As it should be?

Anonymous, please provide a photograph of the screen along with a log from "mythfrontend -v playback".

comment:5 Changed 14 years ago by danielk

Milestone: 0.190.20
Priority: minortrivial
Type: patchenhancement

comment:6 Changed 14 years ago by anonymous

But if you have the same image in both the main video window and the PiP windows, shouldn't the aspect of both windows be the same regardless of the display dimension ?

See new attachments as asked for.

Changed 14 years ago by anonymous

Attachment: PiPScreenShot.jpg added

Screenshot with PiP in Top-Right corner.

Changed 14 years ago by anonymous

Attachment: mythfrontend.log added

mythfrontend log with "playback"

comment:7 Changed 14 years ago by danielk

Resolution: invalid
Status: reopenedclosed

Here is your problem... VideoOutputXv?: Estimated display dimensions: 260x195 mm Aspect: 1.33333 VideoOutputXv?: Estimated window dimensions: 260x195 mm Aspect: 1.33333

Probably due to displaying on a 4:3 monitor. You need to set the DisplaySize? in the "Monitor" section of your xorg.conf something like "DisplaySize? 521 324 # in millimeters"

You could also use MythTV's XRandR config to set the display aspect ratio if using a single monitor (assuming you have XRandR), or use MythTV's Xinerama config to set the display aspect ratio if using Xinerama.

comment:8 Changed 14 years ago by anonymous

Resolution: invalid
Status: closedreopened

When I set the DisplaySize? to 521x324 mm, Myth's main video window aspect is wrong, because the 16:9 DVB image is being stretched vertically, to fill my 4:3 display. Whereas previously, the 16:9 DVB image was displayed with black bars top and bottom on my 4:3 display and in the correct aspect.

Also, changing the DisplaySize? does not fix the PiP aspect.

Any other suggestions ?

comment:9 Changed 14 years ago by danielk

Hmm, I missdiagnosed this.

I thought you had set up your monitor to display a 16:9 image.

It looks like the PiP is not compensating for the stretching properly.

What is the resolution of the video it is displaying?

comment:10 Changed 14 years ago by anonymous

Video images are 720x576 16:9.

comment:11 Changed 14 years ago by danielk

Hmm, I think this might be easy enough to fix...

We adjust for letterboxing, we adjust for non-square pixels on the screen, but we I don't think we are adjusting for non-square pixels in the video in the PiP window...

comment:12 Changed 14 years ago by danielk

Resolution: fixed
Status: reopenedclosed

(In [7665]) Closes #462, by adjusting for non-square pixels in the PiP video.

Note: See TracTickets for help on using tickets.