Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4662 closed patch (fixed)

Fix check for invalid dvd seek in libmythdvdnav

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

In the function dvdnav_sector_search in the file searching.c in libmythdvdnav there is a check to see if the request seek is within the range of the dvd. The check subtracts the offset from the length and then attempts to check if that value is less then zero. Both offset and length are unsigned integers so if offset were larger then length it would underflow and produce a value that is very large. Which means that the conditional doesn't really work as coded. To fix this we just have to change the conditional to see if offset is bigger then length.

Attachments (1)

fix-unsigned-logic-in-dvdnav-searching.patch​ (945 bytes) - added by Erik Hovland <erik@…> 12 years ago.
changes conditional on seek to actually work

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by Erik Hovland <erik@…>

Attachment: fix-unsigned-logic-in-dvdnav-searching.patch​ added

changes conditional on seek to actually work

comment:1 Changed 12 years ago by paulh

Resolution: → fixed
Status: new → closed

(In [16160]) Fix check for invalid dvd seek in libmythdvdnav.

Patch by Erik Hovland. Fixes #4662.

comment:2 Changed 12 years ago by paulh

(In [16161]) Fix check for invalid dvd seek in libmythdvdnav.

Patch by Erik Hovland. Fixes #4662.

Note: See TracTickets for help on using tickets.