Opened 17 years ago
Closed 17 years ago
Last modified 17 years ago
#4662 closed patch (fixed)
Fix check for invalid dvd seek in libmythdvdnav
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
In the function dvdnav_sector_search in the file searching.c in libmythdvdnav there is a check to see if the request seek is within the range of the dvd. The check subtracts the offset from the length and then attempts to check if that value is less then zero. Both offset and length are unsigned integers so if offset were larger then length it would underflow and produce a value that is very large. Which means that the conditional doesn't really work as coded. To fix this we just have to change the conditional to see if offset is bigger then length.
Attachments (1)
Change History (3)
Changed 17 years ago by
Attachment: | fix-unsigned-logic-in-dvdnav-searching.patch added |
---|
comment:1 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
changes conditional on seek to actually work