Opened 12 years ago

Closed 12 years ago

#4828 closed defect (fixed)

why assign when we don't have to?

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

In UIManagedTreeListType::Draw() lnode is assigned to the return value of at() and first(). But those assignments are never used. The at() and first() calls do useful work and should be done. But the assignment is unnecessary. Removing them should reduce machine code size.

Attachments (1)

libs_libmyth_uitypes.cpp-why-assign-when-unnecessary.patch​ (972 bytes) - added by Erik Hovland <erik@…> 12 years ago.
removes assignment from at() and first() return values

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by Erik Hovland <erik@…>

Attachment: libs_libmyth_uitypes.cpp-why-assign-when-unnecessary.patch​ added

removes assignment from at() and first() return values

comment:1 Changed 12 years ago by Isaac Richards

Milestone: 0.21 → 0.22

comment:2 Changed 12 years ago by Nigel

Resolution: → fixed
Status: new → closed

(In [16349]) Remove unwanted assignment. Patch by Erik Hovland. Closes #4828

Note: See TracTickets for help on using tickets.