Opened 12 years ago

Closed 12 years ago

#5263 closed defect (fixed)

Mytharchive renames ProjectX output files incorrectly, resulting in failure

Reported by: thrantastic@… Owned by: paulh
Priority: minor Milestone: 0.21.1
Component: mytharchive Version: 0.21-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When mytharchive renames the output files produced by ProjectX, it will occasionally mix up the files and rename them incorrectly, resulting in failure during further processing. This happens because mythburn.py relies on the stream PIDs found in the ProjectX log appearing in the same order as the corresponding output files in the log. This, evidently, is not always the case.

An example of this behavior follows. ProjectX finds the requested streams (video, audio, subtitle) in the following order (audio, video, subtitle):

-> special PIDs for searching defined: { 0x12D 0x12E 0x12F }
ok> PID 0x12E has PES-ID 0xC0 (MPEG Audio) (1504 #9)
ok> PID 0x12D has PES-ID 0xE0 (MPEG Video) (5640 #31)
ok> PID 0x12F has PES-ID 0xBD (private stream 1) (SubID 0x20)

It then processes the streams in the requested order (video, audio, subtitle), although that may just be coincidental. The mythburn script then pairs up the first stream found (audio) with the first file produced (video) when renaming the files, so it renames the video file incorrectly and does the same with the audio file. I will attach the logfiles showing the exact behavior.

A temporary fix would be to skip the rename logic altogether and use hardcoded renames from *.m2v to stream.mv2, etc. that are already used as a last resort.

Attachments (4)

1020_20080421200000_log.txt (9.7 KB) - added by thrantastic@… 12 years ago.
ProjectX processing log
mythburn.log (54.0 KB) - added by thrantastic@… 12 years ago.
mythburn log, showing renameProjectXFile output and eventual error
streaminfo.xml (910 bytes) - added by thrantastic@… 12 years ago.
streaminfo file
mythburn-stream-order.diff (1.3 KB) - added by anonymous 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by thrantastic@…

Attachment: 1020_20080421200000_log.txt added

ProjectX processing log

Changed 12 years ago by thrantastic@…

Attachment: mythburn.log added

mythburn log, showing renameProjectXFile output and eventual error

Changed 12 years ago by thrantastic@…

Attachment: streaminfo.xml added

streaminfo file

comment:1 Changed 12 years ago by anonymous

I spotted this a while back and reported it together with a patch to mythburn.py, attached here.

Changed 12 years ago by anonymous

Attachment: mythburn-stream-order.diff added

comment:2 in reply to:  1 Changed 12 years ago by paulh

Milestone: unknown0.21.1
Version: head0.21-fixes

Replying to anonymous:

I spotted this a while back and reported it together with a patch to mythburn.py, attached here.

Thanks for the patch Alex. I wanted to do more testing to make sure it doesn't break files with more than one audio stream before committing it. Your patch does make a big assumption that projectx creates the files in stream order which I'm not sure is always the case especially if there are multiple audio streams. If it does then that would simplify things greatly and the stream selection in mythburn.py could be rewritten. I haven't found a file that doesn't work with your patch so I'm going to commit it and hope for the best :-)

comment:3 Changed 12 years ago by paulh

(In [17346]) This should fix mythburn.py sometimes not choosing the correct streams when using projectx as the cutter/demuxer.

Patch from Alex Butcher. Refs #5263.

comment:4 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [17347]) Merge [17346] from trunk.

This should fix mythburn.py sometimes not choosing the correct streams when using projectx as the cutter/demuxer.

Patch from Alex Butcher. Fixes #5263.

Note: See TracTickets for help on using tickets.