Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#5487 closed patch (fixed)

LATM AAC audio stream support

Reported by: paul@… Owned by: janne
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: yes

Description

The IsAudio? check in mpegtables.h is not returning true for stream id 0x11 (MPEG2AudioAmd1). This is the audio stream used for the New Zealand DVB-T freeview|HD platform. I believe Norway and other countries use this too.

Attachments (5)

mythtv-latm.patch (1.4 KB) - added by paul@… 6 years ago.
Patch so stream id 0x11 returns true in IsAudio? call
mythtv-latm.2.patch (1.1 KB) - added by paul@… 6 years ago.
Same patch for trunk
latm-aac.patch (27.0 KB) - added by Paul Kendall <paul@…> 5 years ago.
Previsous patch along with LATM/AAC decoder
fixes-latm-aac.patch (27.6 KB) - added by jyavenard@… 5 years ago.
patch for 0.21-fixes
fixes-latm-aac.2.patch (28.2 KB) - added by jyavenard@… 5 years ago.
Updated patches for 0.21-fixes.. Tested to compile properly

Download all attachments as: .zip

Change History (21)

Changed 6 years ago by paul@…

Patch so stream id 0x11 returns true in IsAudio? call

comment:1 Changed 6 years ago by danielk

  • Owner changed from ijr to danielk
  • Status changed from new to assigned

Changed 6 years ago by paul@…

Same patch for trunk

comment:2 Changed 5 years ago by stuartm

Daniel, what's the hold up on this one?

Changed 5 years ago by Paul Kendall <paul@…>

Previsous patch along with LATM/AAC decoder

comment:3 Changed 5 years ago by Paul Kendall <paul@…>

The patch above is a merge of the previous patch and the changes I have made to libavcodec to support LATM wrapped AAC for DVB-T channels.

comment:4 Changed 5 years ago by anonymous

works for me on Fedora 10 x86_64 and trunk and vdpau.
nice one Paul - NZ Freeview DVB-T is all but there now.

Changed 5 years ago by jyavenard@…

patch for 0.21-fixes

Changed 5 years ago by jyavenard@…

Updated patches for 0.21-fixes.. Tested to compile properly

comment:5 follow-up: Changed 5 years ago by jyavenard@…

I didn't realise that the original patch depended on a newer version of ffmpeg and wouldn't compile with 0.21-fixes.

Updated the patch to compile with 0.21-fixes. I can not guarantee that it works unfortunately as I have no way of testing.

comment:6 Changed 5 years ago by Paul Kendall <paul@…>

latm-aac.patch above is for trunk.
This patch is vital for DVB-T in NZ, Norway and other now too. I, and others have been using the patch for many months without issue.

comment:7 in reply to: ↑ 5 Changed 5 years ago by jyavenard@…

Replying to jyavenard@gmail.com:

Updated the patch to compile with 0.21-fixes. I can not guarantee that it works unfortunately as I have no way of testing.

Patch for fixes has been successfully tested (also compatible with the 0.21 VDPAU patch)...

comment:8 Changed 5 years ago by fritz.hu@…

Have been struggling profusely to get working Freeview|HD here in NZ - LATM/HE-AAC, H.264. Certain channels crash the frontend on playback, and without P. Kendall's myth distro, there is no sound.

This patch does not work for me against the current revision of trunk.

What is keeping this issue from being resolved? Would be happy to help if I could.

comment:9 Changed 5 years ago by Paul Kendall <paul@…>

I am currently getting my patches included in ffmpeg trunk.

Hopefully not too long till it's completed, then when Myth decides to move to trunk of ffmpeg this patch will note be needed.

comment:10 Changed 5 years ago by fritz.hu@…

Thanks for that Paul - can I please have your email address to discuss - I am currently attempting to build Myth trunk to use Freeview|HD for the main purpose of being able to use VDPAU.

I'm currently running your distro off your PPA, working perfectly apart from VDPAU - no idea how to get it going (or if it supports it?)

Can you please let me know what to do to get trunk working? I've got trunk from svn, got and built ffmpeg svn trunk, and applied the patch (including decoder) from this ticket. So far have got VDPAU working, and got great video from all channels but sound only from TV3.

Cheers!

P.S. Apologies for posting this in the ticket comments, pls feel free to delete after answering!

comment:11 Changed 5 years ago by Dibblah

  • Ticket locked set

Trac is not a support forum.

comment:12 Changed 5 years ago by janne

  • Milestone changed from unknown to 0.22
  • Owner changed from danielk to janne

comment:13 Changed 5 years ago by stuartm

If this feature stands any chance of appearing in 0.22 we need a working patch against current trunk.

comment:14 Changed 5 years ago by janne

(In [21467]) add stream id fro AAC LATM audio, Refs #5487

comment:15 Changed 5 years ago by janne

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [21468]) Add AAC/LATM parsing/decoding. Fixes #5487

make distclean required. LATM supports depends on libfaad
based on patch by Paul Kendall

comment:16 Changed 5 years ago by janne

(In [21488]) updates LATM support to latest version from Paul Kendall, Refs #5487

fixes a sample, is smaller and looks nicer

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.