Opened 14 years ago

Closed 11 years ago

#554 closed defect (fixed)

Match duplicates using subtitle & description needs to also check partnumber/parttotal

Reported by: jppoet@… Owned by: gigem
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: scheduler duplicates
Cc: Ticket locked: no

Description (last modified by danielk)

I noticed this a long time ago, but have been waiting for a good example.

Some mini-series shows will designate every episode with the exact same Title/Subtitle/Programid?. The only difference is the (Part X of Y) in the program information.

A current example (as of 31Oct05), is "Category 7: The End of the World". If you set up this show to record with "Match duplicates using subtitle & description), the second part will not record because it think it is the same as the first part.

If Bruce or David does not want to look at doing a "quick" fix for this, I will look into it. I am barely more than a beginner with SQL, however.

John

Attachments (3)

programid-part.patch (2.0 KB) - added by jppoet@… 11 years ago.
Fudge programids to include the part number as necessary to make the programid unique
programid-part-fixes.patch (2.0 KB) - added by jppoet@… 11 years ago.
Version for -fixes (maybe). No guarantee it still applies.
programid-part-v1.1.patch (2.5 KB) - added by jppoet@… 11 years ago.
include parttotal as part of fudged programid

Download all attachments as: .zip

Change History (11)

comment:1 Changed 14 years ago by danielk

Description: modified (diff)
Milestone: 0.20
Owner: changed from Isaac Richards to gigem
Version: head

comment:2 Changed 13 years ago by Isaac Richards

Milestone: 0.200.21

comment:3 Changed 12 years ago by Janne Grunau

Milestone: 0.21unknown

comment:4 Changed 11 years ago by Dibblah

Status: newassigned

Changed 11 years ago by jppoet@…

Attachment: programid-part.patch added

Fudge programids to include the part number as necessary to make the programid unique

comment:5 Changed 11 years ago by jppoet@…

I have attached a patch to this ticket which causes the programid to be fudged to include the mini-series "part". This is necessary for some mini-series such as "The Last Templar", which use the same programid for all the episodes. Without this patch, myth would only record the first episode of the series.

Bruce rejected this approach a few years ago, but never came up with a better solution, So I am throwing out there again.

Changed 11 years ago by jppoet@…

Attachment: programid-part-fixes.patch added

Version for -fixes (maybe). No guarantee it still applies.

comment:6 in reply to:  5 Changed 11 years ago by gigem

Replying to jppoet@gmail.com:

I have attached a patch to this ticket which causes the programid to be fudged to include the mini-series "part". This is necessary for some mini-series such as "The Last Templar", which use the same programid for all the episodes. Without this patch, myth would only record the first episode of the series.

While I don't see this hack as ideal, I've yet to think of any better solution. I'd certainly rather have this than add part number into the mix everywhere duplicate checking is done.

John, do you think you should encode the total number of parts in the programid as well?

Bruce rejected this approach a few years ago, but never came up with a better solution, So I am throwing out there again.

If Bruce still doesn't like it, he can come out of hiding and restate his case.

Changed 11 years ago by jppoet@…

Attachment: programid-part-v1.1.patch added

include parttotal as part of fudged programid

comment:7 Changed 11 years ago by jppoet@…

As requested by David...

programid-part-v1.1.patch includes parttotal as part of fudged programid.

comment:8 Changed 11 years ago by gigem

Resolution: fixed
Status: assignedclosed

(In [20318]) Applied a patch from John Poet (with a fix by me) to modify the programids of some multi-part programs to make them unique. The intent is to make sure successive parts don't get marked as duplicates after an earlier part is recorded. This hack isn't ideal, but it's better, IMO, than changing the code to also compare part numbers everywhere programids are compared.

Fixes #554.

Note: See TracTickets for help on using tickets.