Opened 11 years ago

Closed 11 years ago

#5570 closed defect (fixed)

Remove most Qt3 stuff from libmythtv

Reported by: danielk Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch removes most Qt3 things from the libmythtv library. The remaining stuff either uses Qt networking stuff or is in libmyth headers.

This also patches some bits of the libmyth & programs directories as needed for de-Qt3-ifying libmythtv.

This has been mildly tested by me so far, any additional testing is appreciated, especially systematic testing.

Attachments (4)

5570-v1.patch (230.6 KB) - added by danielk 11 years ago.
5570-channel-v4.patch (31.6 KB) - added by danielk 11 years ago.
Channel portion remaining
5570-mhi-v4.patch (17.7 KB) - added by danielk 11 years ago.
MHEG portion remaining
5570-quartz-v4.patch (7.1 KB) - added by danielk 11 years ago.
OSX portion remaining

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by danielk

Attachment: 5570-v1.patch added

comment:1 Changed 11 years ago by danielk

(In [17929]) Refs #5570. Commits ProgramInfo? portion of Qt3 removal patch.

This is one of the less rote conversions so I separated out so I could test it independently, and if needed revert it independently.

comment:2 Changed 11 years ago by danielk

(In [17930]) Refs #5570. Qt3->Qt4 conversions for libmythtv. This is the bulk of the conversion patch, excliding only the bits I can't test or are complex enough to require more testing.

Note: you will need to recompile the plugins and a distclean is recommened.

Changed 11 years ago by danielk

Attachment: 5570-channel-v4.patch added

Channel portion remaining

Changed 11 years ago by danielk

Attachment: 5570-mhi-v4.patch added

MHEG portion remaining

Changed 11 years ago by danielk

Attachment: 5570-quartz-v4.patch added

OSX portion remaining

comment:3 Changed 11 years ago by danielk

I've split the remaining Qt3->Qt4 conversions for libmythtv into three patches:

  • MHI -- I can't test this, and apparently no one can at the moment.
  • Quartz -- I can't test this, but it's probably good to go.
  • Channel -- This needs more work, the existing locking was insufficient, but I need to audit all the channel classes to make sure we don't add more locking than we need since some of the Channel classes already have some locking.

comment:4 in reply to:  3 Changed 11 years ago by Stuart Auchterlonie

Replying to danielk:

I've split the remaining Qt3->Qt4 conversions for libmythtv into three patches:

  • MHI -- I can't test this, and apparently no one can at the moment.

I can test this as it's integral to the MHEG stuff that i'm having a bash at.

comment:5 Changed 11 years ago by danielk

(In [17957]) Refs #5570. Gets rid of URLFetcher, httpcomms handles everything we were using it for & URLFetcher is using Qt3 stuff.

comment:6 Changed 11 years ago by danielk

(In [17958]) Refs #5570. Fixes one url type not handled by the old url fetcher not handled by http comms, file.

comment:7 Changed 11 years ago by danielk

(In [17959]) Refs #5570. Convert IPTVFeederFile from Q3Url to QUrl.

comment:8 Changed 11 years ago by Nigel

(In [17971]) Refs #5570. Daniel's patch was perfect, bar a typo and an interesting warning:

videoout_quartz.cpp: In member function 'void QuartzData::ClearViews()':
videoout_quartz.cpp:108: warning: possible problem detected in invocation of delete operator:
videoout_quartz.cpp:108: warning: invalid use of undefined type 'struct VideoOutputQuartzView'
videoout_quartz.cpp:68: warning: forward declaration of 'struct VideoOutputQuartzView'
videoout_quartz.cpp:108: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined.

which warranted a slight re-org of the internal class def'ns. Seems to work OK.

comment:9 Changed 11 years ago by danielk

(In [17974]) Refs #5570. More Qt4 conversions for libmythtv.

comment:10 Changed 11 years ago by danielk

Resolution: fixed
Status: newclosed

(In [18623]) Fixes #5570. Partial conversion of MHI in libmythtv to Qt4. Remaining portion requires someone in UK to work on.

Note: See TracTickets for help on using tickets.