Opened 11 years ago

Closed 11 years ago

#5646 closed defect (fixed)

{trunk} MythXML::GetKeys in mythbackend doesn't actually get any keys

Reported by: anonymous Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When daniel refactor for the Qt4 port the member function GetKeys?() added the variable 'uint nCount'. And it was initialized to zero. That variable is not made part of the HTTPRequest or the query so it is never updated. Then a little later a test is made to see if nCounts is zero (which it still is) and GetKeys? returns w/out ever updating the list with the keys and the count.

This gets recognized as a dead code defect in the static analysis checker. But this is likely a deeper bug.

Attachments (1)

programs_mythbackend-dead-code.patch (643 bytes) - added by Erik Hovland <erik@…> 11 years ago.
Adds an increment instruction for nCounts so GetKeys? keeps working

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Erik Hovland <erik@…>

Adds an increment instruction for nCounts so GetKeys? keeps working

comment:1 Changed 11 years ago by danielk

Milestone: unknown0.22
Owner: changed from Isaac Richards to danielk
Status: newaccepted

comment:2 Changed 11 years ago by danielk

Resolution: fixed
Status: acceptedclosed

(In [18199]) Fixes #5646. Applies fix from Erik Howland for a blunder I made in the Qt4 conversion in libmythtv.

Note: See TracTickets for help on using tickets.