Modify

Opened 9 years ago

Closed 8 years ago

#5745 closed enhancement (fixed)

IMONLCD Icon Support in mythlcdserver and mythfrontend/plugins

Reported by: Markus Schulz <msc@…> Owned by: jarod
Priority: minor Milestone: unknown
Component: MythTV - Mythlcdserver Version: head
Severity: low Keywords:
Cc: jarod Ticket locked: no

Description

An _early_ version for support of the icons from the imonlcd (NOT VFD).

currently done (used icons):

  • support for speaker setup (2ch/5.1/7.1/spdif-passthru)
  • support for audio/video Codec Icons (bottom side)+hdtv-icon
  • Function select for TV/Music/Movie

TODO:

  • cd/dvd spinning icon on cd/dvd-access
  • cd/dvd insert symbol
  • news/gallery/web/... icons en/disabled inside plugins
  • tuner-selections (SRC/SRC1/SRC2)
  • backend recording status (REC)
  • repeat/shuffle in mythmusic
  • something usefull for the other icons...

find the best place to enable/disable the icons inside the plugins is very time consuming, any help is appreciated

Attachments (2)

imonlcd_trunk@18320.diff.gz (12.0 KB) - added by Markus Schulz <msc@…> 9 years ago.
lcd-icon-support.patch (22.6 KB) - added by jarod 8 years ago.
Updated version, now sets channels based on source material

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by Markus Schulz <msc@…>

comment:1 in reply to: ↑ description Changed 9 years ago by avdongen@…

Replying to Markus Schulz <msc@antzsystem.de>:

Hi, I had a quick look at your patch, and I was wondering if the defined constants like SPEAKER_MASK are specific for this display. It would be nice if the device-specific constants could be left outside Mythtv's knowledge and under LCDproc control. But that requires LCDproc support for icons and I haven't looked at that yet. BTW, I have both a Medion MD8800 display and a ShuttleVFD display available for testing. So if we can make it work on these, I would be glad.

Regards, Arthur

comment:2 Changed 9 years ago by paulh

  • Component changed from mythtv to MythTV - Mythlcdserver
  • Owner changed from ijr to paulh
  • Status changed from new to assigned

comment:3 Changed 9 years ago by ryebrye@…

Good to see work being done on this.

There is a patch for lcdproc that provides icon support in LCDProc itself

(see: http://article.gmane.org/gmane.comp.sysutils.lcdproc/12788/match=imon and http://article.gmane.org/gmane.comp.sysutils.lcdproc/12789/match=imon )

It might be worthwhile to implement patches based upon that patch to LCDProc (well, and try to get the LCDproc people to commit it to CVS so that we don't work against a moving target)

One feature I would like to see is the progress bars on the actual LCD used instead of using the character space for them. It has several rows of dots that can be used for progress bars that are outside of the normal character area, in addition to all the nice other icons available on the display.

comment:4 Changed 8 years ago by jarod

  • Cc jarod added

So the updated version of the patch basically works, but not 100% correctly. I'm getting only L and R lit up for audio channels, even on 5.1 AC3 audio, and at least the one mkv file I tried playing in mythvideo lit up the TV icon instead of the Video (or Movie?) icon, and claimed to be an MPEG instead of AVC or h.264 or whatever (didn't look too closely at the code to see if maybe its being reported as MPEG4 which maybe lights up MPEG...). The L and R audio icons aren't being cleared on exit from recordings either. Will do some more debugging and patching later.

comment:5 Changed 8 years ago by jarod

h.264 does simply report as MPEG, so that part was correct, and I've got the audio icons being cleared now as well. Watching stuff in mythvideo currently sets the TV icons, then on exit, sets the MOVIE icon, but I may have that fixed now (need to test still). Also have a possible fix for audio channels I need to test.

My only real concern left, assuming my fixes above work, is what happens on displays without these icons. Otherwise, I think I'm game to go ahead and commit this.

Changed 8 years ago by jarod

Updated version, now sets channels based on source material

comment:6 Changed 8 years ago by jarod

  • Owner changed from paulh to jarod

This version is against svn trunk at r22413, and behaves pretty much 100% correctly now, so far as I can tell, at least for mythtv and mythvideo. Haven't been able to get it tested on a VFD w/o icons, but I broke down and bought an iMON VFD device today, since I needed/wanted another iMON device to do lirc dev work on anyway... I'd sort of like to sneak this in for the 0.22 release, but its a bit too late now. Maybe it'll be in 0.22.1, definitely in 0.23. :)

comment:7 Changed 8 years ago by jarod

(In [22477]) Initial support for some of the icons on iMON LCD devices

First round of additions to enable lighting up the speaker, codec and a few function icons on iMON LCD devices. Not sure if this works with any other display with icons, but it doesn't harm an iMON VFD w/o icons...

Works quite well with mythtv and mythvideo, when the internal player is used, other plugins aren't particularly well fleshed out, and using an external player for mythvideo only lights up the MOVIE function icon, but that's to be expected...

Additional patches for supporting lighting more icons and support for more of the plugins would be appreciated, not sure if I'll get around to 'em myself anytime soon... This much is a nice start though (thanks to Markus Schulz for the original patch).

Refs #5745.

comment:8 Changed 8 years ago by jarod

(In [22513]) lcddevice: disentangle libmythdb and libavcodec

Move conversion from specific av codec to a generic codec that has an icon available on imon lcds into avformatdecoder. This way, we eliminate the unnecessary dependency on libavcodec in libmythdb, and the resulting code is actually much smaller and cleaner. (Thanks be unto Isaac for pointing out how crappily things were being done, as well as to Janne and Jean-Yves for the interim build fixage). Still works just as well on my own iMON LCD.

comment:9 Changed 8 years ago by robertm

  • Resolution set to fixed
  • Status changed from assigned to closed

Closing as the original aim of the ticket has been accomplished. Tickets to add to the baseline support are very welcome.

Add Comment

Modify Ticket

Action
as closed The owner will remain jarod.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.