Opened 11 years ago

Closed 11 years ago

#5980 closed patch (fixed)

Patches required to make win32 succeed (against r19247)

Reported by: Jonathan Martens <jonathan@…> Owned by: Nigel
Priority: minor Milestone: 0.22
Component: windows Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

After some serious trying and some conversation on the mailinglist (http://mythtv.org/pipermail/mythtv-dev/2008-December/063829.html) here is the list of patches I need to compile MythTV on windows using Qt 4.4.3 and MinGW-5.1.4.

Attachments (11)

MythTV-bswap.h.patch (547 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
MythTV-compat.h.patch (1.5 KB) - added by Jonathan Martens <jonathan@…> 11 years ago.
MythTV-dvd_reader.c.patch (558 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
MythTV-H264Parser.cpp.patch (1.1 KB) - added by Jonathan Martens <jonathan@…> 11 years ago.
MythTV-H264Parser.h.patch (2.9 KB) - added by Jonathan Martens <jonathan@…> 11 years ago.
MythTV-pthread.c.patch (451 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
Qt-qatomic_windows.h.patch (653 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
MinGW-sched.h.patch (489 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
MinGW-sspi.h.patch (288 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
MinGW-stdlib.h.patch (610 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
MythTV-H264Parser.h-new.patch (411 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.
New patch for H264Parser.h (to define uint by means of including ../../libmythdb/compat.h

Download all attachments as: .zip

Change History (22)

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MythTV-bswap.h.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MythTV-compat.h.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MythTV-dvd_reader.c.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MythTV-H264Parser.cpp.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MythTV-H264Parser.h.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MythTV-pthread.c.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: Qt-qatomic_windows.h.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MinGW-sched.h.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MinGW-sspi.h.patch added

Changed 11 years ago by Jonathan Martens <jonathan@…>

Attachment: MinGW-stdlib.h.patch added

comment:1 Changed 11 years ago by Dibblah

Status: newassigned

comment:2 Changed 11 years ago by davidbuzz@…

I can confirm that the pthread,c, dvd_reader.c , and bswap.h patches as above are identical to the changes I've had to make. As for the H264* files, I made a simpler change to include compat.h to get uint defined. +++ libs/libmythtv/mpeg/H264Parser.h (working copy) @@ -23,6 +23,7 @@

#ifndef H264PARSER_H #define H264PARSER_H

+#include "../../libmythdb/compat.h" for uint on win32

#include <stdint.h> #include <sys/types.h> for uint on Darwin

Regarding the changes that relate to the MinGW build environment, sched.h is tested too. I haven't tried the sspi or stdlib patches yet. :-(

Changed 11 years ago by Jonathan Martens <jonathan@…>

New patch for H264Parser.h (to define uint by means of including ../../libmythdb/compat.h

comment:3 Changed 11 years ago by danielk

Owner: changed from danielk to Nigel

comment:4 Changed 11 years ago by Nigel

(In [19821]) Another MinGW build fix. See #5980, #4397

comment:5 Changed 11 years ago by davidbuzz@…

notes: [19819] fixes the bswap, dvd_reader issues with WIN32/_WIN32 by defining WIN32 explicity. [19820] fixes H264Parser.h ( the the H264Parser.c change is not required anymore ) [19822] releases new win32packager.pl that patches the 3xMinGW and 1xQt patches dynamically when running.

So this ticket can now be closed. Buzz.

comment:6 Changed 11 years ago by Nigel

The compat.h patch - usleep() removal - may still be needed, or worth investigating?

comment:7 Changed 11 years ago by davidbuzz@…

I didn't find it necessary. Buzz.

comment:8 Changed 11 years ago by Steltek

As far as I can see, the patches are not being applied, even in [19822] (the respective lines are commented out in the script).

comment:9 Changed 11 years ago by anonymous

Steltek, please discuss your issues on the -dev list. trac is for patches.

comment:10 Changed 11 years ago by Nigel

(In [19841]) Enable another ghastly MinGW patch. See #4397, #5980.

comment:11 Changed 11 years ago by Nigel

Resolution: fixed
Status: assignedclosed

(In [19910]) Take the hacky sleep() out of compat.h - under MinGW 5.1.4, unistd.h has a declaration for this (and presumably the libs have an implementation). Thanks to Jonathan Martens. Closes #5980.

Note: See TracTickets for help on using tickets.