Opened 11 years ago

Closed 11 years ago

#6172 closed defect (invalid)

disable getPreviewImage when gui option un-checked

Reported by: jrigg@… Owned by: stuartm
Priority: trivial Milestone: 0.22
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

generating preview images in Recordings List takes way too long and the checkbox to disable isn't ever used in the code. Add this code to honor the checkbox selection:

in mythtv/programs/mythfrontend/playbackbox.cpp [19810]

at line 3503 in QString PlaybackBox::getPreviewImage

+ + if (!gContext->GetNumSetting?("GeneratePreviewPixmaps?",0)) + return filename; +

Change History (3)

comment:1 Changed 11 years ago by stuartm

Milestone: unknown0.22
Owner: changed from Isaac Richards to stuartm
Priority: minortrivial
Status: newassigned

Not sure I really see the point of this, it was removed from the mythui ported version for a reason.

comment:2 in reply to:  1 Changed 11 years ago by anonymous

Replying to stuartm:

Not sure I really see the point of this, it was removed from the mythui ported version for a reason.

And that reason was?

-Too many options for the user. We should eliminate what we deem as unnecessary and force (possibly unwanted) functionality down their throats.

  • The Code is too fat, and a lines is a lines no matter how small.
  • Your explanation here.

I used to think the goal of a Mythfrontend box would be $100 for a small silent HD capable device. Thanks to VDPAU that is achievable now. I have lowered my goal to $50. Such a device is often diskless and uses a read-only root file system. It takes over ten seconds to generate thumbnails that aren't already cached, and in the system I described, the cache is eliminated every power cycle. This makes parts of the gui unresponsive and irritating. Forcing eye candy on the user at the expense of unresponsive irritating performance smells of MicroSoft? mentality. Just my opinion.

Anyway, if your going to remove it, then the themes shouldn't still have the check boxes.

comment:3 Changed 11 years ago by stuartm

Resolution: invalid
Status: assignedclosed

I'll happily make it so that if you pick a theme which doesn't use preview images then they won't be generated. Want to use an existing theme which does? Then edit the theme.

As far as the setting not having been removed yet, well this is trunk, such things happen and they will get cleaned up by the next release.

Note: See TracTickets for help on using tickets.