Opened 11 years ago

Closed 11 years ago

#6333 closed defect (fixed)

Fanart directory setting inconsistent

Reported by: paul [at] planar.id.au Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The fanart directory setting in the setting table that is saved by the settings screen is "mythvideo.fanartDir", the setting that is read by videodlg.cpp is "VideoFanartDir?". So far as I can tell the more standard is that written by the settings screen, so this patch changes videodlg.cpp to use that.

I also noticed that "VideoArtworkDir?" is used - I've changed this also to "mythvideo.screenshotDir" as that appears in the settings table - but it isn't clear to me that VideoArtworkDir? is screenshot, as opposed to banner.

In looking to work out what VideoArtworkDir? might be I noticed that in videodlg.cpp, m_artdir and m_fandir have quite different usage - I kind of assumed they would be similar. I can't be sure without knowing the code better, but it looks to me like the settings screen recognises:

  • banners
  • fanart
  • screenshots
  • plus the things it already recognised

videodlg.cpp seems to recognise fanart and videoartwork. So they look to be out of synch with each other.

Anyway, I patched what I could, and leave the rest for someone who knows the code better.

PS: Thanks heaps for the fanart patches - I'm excited by what they might mean for themes, and it is great to see this area being worked on so actively.

Attachments (1)

videodlg.cpp.patch (283 bytes) - added by paul [at] planar.id.au 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by paul [at] planar.id.au

Attachment: videodlg.cpp.patch added

comment:1 Changed 11 years ago by robert.mcnamara@…

I haven't looked at this patch, but I've fixed this error (has to do with me implementing it one way, then going back and changing the settings values-- works for me sine I have both values, but nobody else would-- d'oh!)

For everyone's reference, the fanart download stuff is temporary until the new metadata handling code gets in... to get fanart and poster download on *existing* items, you'll need to reset the item's metadata and rm the poster file. Then when you re-download the metadata you should get the metadata, poster, and fanart.

comment:2 Changed 11 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [20151]) Fix setting name. Patch from Robert McNamara?. Close #6333

Note: See TracTickets for help on using tickets.