Opened 11 years ago

Closed 10 years ago

#6360 closed enhancement (wontfix)

exit to os protection and reboot menu option

Reported by: jorcas33@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: MythTV - Mythwelcome & Mythshutdown Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

As I have both Linux and windows in the same machine I find useful to have this option, so, I added a new menu option reboot

I also want to have some protection to forbidden non admin user to exiting Mythwelcome and playing arround the linux OS, so I added a password protection when user select EXIT menu option (I used the same general configuration password), if there isn't a config password, then it works as no protection

Attachments (1)

exit-protect-reboot.diff (4.8 KB) - added by jorcas33@… 11 years ago.
patch from svn diff (release 20211)

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by jorcas33@…

Attachment: exit-protect-reboot.diff added

patch from svn diff (release 20211)

comment:1 Changed 11 years ago by laga

Status: newinfoneeded_new

Hey,

I just looked at your patch. Seems like a good thing to have. However, I found some issue.

  • Why are you duplicating checkPinCode()? It's already present in myththemedmenu.cpp/.h
  • Please use .isEmpty() instead of != ""
  • It seems you copied WelcomeDialog::rebootNow(void) from WelcomeDialog::shutdownNow(void). Several issues with that:
    • Code duplication is bad (and the conversion for some of the VERBOSE messages and comments is incomplete)
    • You don't set the wakeup time

Of course, some of these issues might have been in the original code on which you based your patch 4 months ago.

In any case, this patch can't be committed as it is. Can you provide an updated version?

Feel free to ask any questions you might have on the developer mailing list.

Regards,

Michael

comment:2 Changed 10 years ago by robertm

Resolution: wontfix
Status: infoneeded_newclosed

Info/changes not provided within six weeks. Would also need to be implemented to hook into the functionality added in r20852.

Note: See TracTickets for help on using tickets.