Opened 15 years ago
Closed 15 years ago
#6360 closed enhancement (wontfix)
exit to os protection and reboot menu option
| Reported by: | Owned by: | Isaac Richards | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - Mythwelcome & Mythshutdown | Version: | unknown |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
As I have both Linux and windows in the same machine I find useful to have this option, so, I added a new menu option reboot
I also want to have some protection to forbidden non admin user to exiting Mythwelcome and playing arround the linux OS, so I added a password protection when user select EXIT menu option (I used the same general configuration password), if there isn't a config password, then it works as no protection
Attachments (1)
Change History (3)
Changed 15 years ago by
| Attachment: | exit-protect-reboot.diff added |
|---|
comment:1 Changed 15 years ago by
| Status: | new → infoneeded_new |
|---|
Hey,
I just looked at your patch. Seems like a good thing to have. However, I found some issue.
- Why are you duplicating checkPinCode()? It's already present in myththemedmenu.cpp/.h
- Please use .isEmpty() instead of != ""
- It seems you copied WelcomeDialog::rebootNow(void) from WelcomeDialog::shutdownNow(void). Several issues with that:
- Code duplication is bad (and the conversion for some of the VERBOSE messages and comments is incomplete)
- You don't set the wakeup time
Of course, some of these issues might have been in the original code on which you based your patch 4 months ago.
In any case, this patch can't be committed as it is. Can you provide an updated version?
Feel free to ask any questions you might have on the developer mailing list.
Regards,
Michael
patch from svn diff (release 20211)