Opened 15 years ago
Closed 15 years ago
#6421 closed patch (fixed)
Pseudo-hashes are deprecated at ./tmdb.pl line 268.
| Reported by: | Owned by: | Anduin Withers | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | Plugin - MythVideo | Version: | head |
| Severity: | medium | Keywords: | tmdb.pl Pseudo-hashes deprecated concatenation |
| Cc: | Ticket locked: | no |
Description
I am running an issue with the tmdb.pl from this ticket. All my other movie backdrop downloads work fine with the exception of Dead Like Me: Life After Death. Examples: This one works fine. “Babylon A.D.” # ./tmdb.pl -M "Babylon A.D." 0364970:Babylon A.D. (2008)
# ./tmdb.pl -B 0364970 http://www.themoviedb.org/image/backdrops/3314/tt0364970-2.jpg http://www.themoviedb.org/image/backdrops/5402/tt0364970.jpg http://www.themoviedb.org/image/backdrops/18590/Babylon_AD.jpg
This one does not. (Dead Like Me: Life After Death) # ./tmdb.pl -M "Dead Like Me: Life After Death" 1079444:Dead Like Me: Life After Death (2009) 1079444:Dead like Me-Life After Death
# ./tmdb.pl -B 1079444 Pseudo-hashes are deprecated at ./tmdb.pl line 268. Use of uninitialized value in concatenation (.) or string at ./tmdb.pl line 87. Can't use string ("You need to search for something") as a HASH ref while "strict refs" in use at ./tmdb.pl line 275.
Attachments (4)
Change History (13)
Changed 15 years ago by
| Attachment: | tmdb.fix.diff added |
|---|
comment:3 Changed 15 years ago by
| Component: | MythTV - General → Plugin - MythVideo |
|---|---|
| Owner: | changed from Isaac Richards to Anduin Withers |
| Type: | defect → patch |
| Version: | unknown → head |
comment:4 Changed 15 years ago by
This isn't a total solution, as this change fixes one but breaks another (Pinocchio) ("Not an array reference"). Should be obvious to someone who actually knows perl. :)
Changed 15 years ago by
| Attachment: | tmdb.pl.patch added |
|---|
Fix array detection after the data structure is parsed from the XML
comment:5 Changed 15 years ago by
Tested and confirmed against all ticket examples here. Thanks, Michelle.
Changed 15 years ago by
| Attachment: | tmdb.pl_v3.patch added |
|---|
comment:7 Changed 15 years ago by
Michael T Dean reported a new issue: Not an ARRAY reference at ./tmdb.pl line 182 (happens with ./tmdb.pl -D 1126596)
I've fixed tmdb.pl for the above issue use: tmdb.pl_v3.patch
There are more places where this could happen in the code and I will look into them and fully patch the code. Expect an update in the next few days.
Michelle
Changed 15 years ago by
| Attachment: | tmdb.pl_v4.patch added |
|---|
comment:8 Changed 15 years ago by
I've gone through the code and updated the problem areas with a cleaner fix and checked for any other areas that may have had the same issue. I think I've caught them all and I tested by running through all of the examples in this ticket and they are all working fine.
Use the new patch tmdb.pl_v4.patch
Michelle
Fix.