Opened 12 years ago

Closed 12 years ago

#6437 closed defect (fixed)

Scheduling options in override should be copied from original scheduling options

Reported by: anonymous Owned by: gigem
Priority: minor Milestone: unknown
Component: MythTV - Scheduling Version: head
Severity: medium Keywords: override schedule
Cc: Ticket locked: no


If there's a scheduled recording that won't normally be recorded (e.g. because it's early or late showing), and if I override that ("Record anyway"), the show will start and end recording on time.

Start time end end time should be the same as in other recordings (i.e. not overriden). I.e., if I have a show set to record 20 minutes early end end 20 minutes late, then when I create override ("Record anyway"), the override should also start 20 minutes early and end 20 minutes late, without the need to set these numbers separately.

Attachments (1)

setchanged1.patch (6.7 KB) - added by gigem 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by gigem

Attachment: setchanged1.patch added

comment:1 in reply to:  description Changed 12 years ago by gigem

Owner: changed from bjm to gigem
Status: newassigned

This probably got broken in or around [17794] when the Storage and Settings classes were decoupled. The setchanged1 patch is probably along the lines of what needs to be done. In extremely limited testing, it appears to fix the problem at hand, but I have no idea what else it might break. I'd like someone else to review it before I commit it.

comment:2 Changed 12 years ago by gigem

Resolution: fixed
Status: assignedclosed

(In [20384]) Moved the Setting::Is/SetChanged?() functionality which got broken in a previous refactoring into [SimpleDB]Storage::Is/SetSaveRequired?(). Fixes #6437.

Note: See TracTickets for help on using tickets.