Opened 11 years ago

Closed 11 years ago

#6547 closed enhancement (duplicate)

Allow to play video using default external player

Reported by: jyavenard@… Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi

I've configured all known video extensions in my mythtv install to play using the "Internal" player. This is very elegant, provides consistency in the UI across mythtv and add extra features like remember the last position etc...

However, there are still plenty of videos that the internal player can't play properly. As such, there times where I would like to use the default external player (e.g. mplayer) without any fuss and very quickly. Typically, try playing the video, realising that it won't work I can start mplayer , all using my remote control.

This is what this patch does: In 0.21-fixes, pressing I (Info): In trunk (0.22), pressing M (Menu):

Underneath the standard entry "Watch This Video" adds a "Watch This Video (default player)". Which will start playing the video using the default player

Attachments (2)

mythvideodefaultplayer-trunk.patch (5.1 KB) - added by anonymous 11 years ago.
Patch for trunk (20545)
mythvideodefaultplayer-fixes.patch (9.8 KB) - added by jyavenard@… 11 years ago.
patch for 0.21-fixes

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by anonymous

Patch for trunk (20545)

Changed 11 years ago by jyavenard@…

patch for 0.21-fixes

comment:1 Changed 11 years ago by paulh

There's a patch on #6029 that does the same thing.

comment:2 Changed 11 years ago by jyavenard@…

Oh well.. spent time for nothing then :)

Looking at the other patch, you have to define an alternative player and explicitly set the command line. My patch uses the default player set in VideoDefaultPlayer? which by default is mplayer.

As such there's no need for the user to configure anything

comment:3 Changed 11 years ago by managementboy@…

could this feature be used for standard mythtv too? sometimes I import a recording with mythnettv and can't play it back correctly. It would be really nice to be able to switch to a different player for those.

comment:4 Changed 11 years ago by Rob Smith

Status: newinfoneeded_new

We are using the internal player as the default one for 0.22, so with that in mind, would this patch even work? as the VideoDefaultPlayer? is internal, not mplayer.

comment:5 Changed 11 years ago by jyavenard@…

The internal player would be set to "Internal" only on brand new installation.

For any one upgrading from an existing installation, the default player would still be set to "mplayer".

So yes, that patch would still work under these circumstances. For one where the default player is set to Internal, then it would just play normally and start the internal player.

I personally would keep the ability to play in a different player, for the rare cases a video do not play with the Internal player... There are still some unfortunately

comment:6 Changed 11 years ago by stuartm

I've always been concerned that offering the option of an alternative player means that people don't report the problems they have with the internal player.

Now the internal player and mplayer both use ffmpeg and at least in principle they should both be able to play the same content. Doesn't allowing an alternative for the 1/2% of videos which won't play seem like the wrong approach, holding back the internal player rather than focusing on addressing remaining issues?

One of the big reasons why we're moving away from external applications is the drive for better integration, consistency of behaviour and simplification of the setup/settings. We know that offering the choice causes a lot of confusion for users, they have wonder why their remote works for watching recordings but not livetv, why the OSD is missing/different, why audio volumes/devices etc are changing and the list goes on.

comment:7 Changed 11 years ago by robertm

Resolution: duplicate
Status: infoneeded_newclosed

Cross reference to #6029. I'm going to close this one as a duplicate but leave the other open and reference this one for when the final solution is decided upon. I recognize that each approach has its merits/advocates. My personal preference is for a unique alternate player setting, but I don't have strong feelings either way and will defer to Anduin for a final solution.

Note: See TracTickets for help on using tickets.