Opened 11 years ago

Closed 11 years ago

#6770 closed patch (fixed)

CD rips to ogg don't play in iAudio7 player

Reported by: noah711@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: Plugin - MythMusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I've been patching vorbisencoder.cpp for years because the call to ogg_stream_init with serialnumber=0 breaks playback of ripped files in my iAudio7. Don't know if this is a problem for other players, but I think the patch shouldn't break anything for others (just replaces 0 with rand()). Thought I'd finally try submitting it. Thanks for all the great work!

Attachments (1)

ogg_serial_number.patch (681 bytes) - added by noah711@… 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by noah711@…

Attachment: ogg_serial_number.patch added

comment:1 in reply to:  description Changed 11 years ago by noah711@…

sorry, the "Component" should have been MythMusic. Apologies, it's my first ticket!

comment:2 Changed 11 years ago by paulh

Component: MythTV - GeneralPlugin - MythMusic
Owner: changed from Isaac Richards to stuartm

comment:3 Changed 11 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [21451]) Ogg supports a randomly generated 'serial number' for streams which the mythmusic encoder never supplied. It's not really clear what purpose these numbers serve and playback works in most applications with them, but not the iAudio7 hardware player. This adds the random serial number to ogg_stream_init(), based on patch by noah711. Fixes #6770

Note: See TracTickets for help on using tickets.