Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6823 closed defect (fixed)

build failure with gcc 4.4 on powerpc

Reported by: Jarod Wilson Owned by: Janne Grunau
Priority: minor Milestone: 0.22
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Build failure with svn trunk, rev 21118, with gcc 4.4 on powerpc. Updating to latest trunk will try again to be sure its still broken, but didn't see anything committed 'til now (21174) that looked relevant.

...
gcc -c -pipe -fomit-frame-pointer -O3 -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -maltivec -mabi=altivec -pthread -g -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -fno-math-errno -fno-signed-zeros -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -fPIC -DPIC -fno-common -w -fPIC -D_REENTRANT -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include -I/usr -I../../libs/libavcodec -o idct.o idct.c
cd libmythfreesurround/ && make -f Makefile 
make[2]: Entering directory `/builddir/build/BUILD/mythtv-0.22/mythtv-0.22/libs/libmythfreesurround'
g++ -c -pipe -fomit-frame-pointer -O3 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -maltivec -mabi=altivec -g -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -Wno-non-virtual-dtor -funit-at-a-time -D__STDC_CONSTANT_MACROS -pthread -I/usr/include/kde/artsc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fPIC -DPIC -w -fPIC -D_REENTRANT -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore -I/usr/include/QtGui -I/usr/include -I/usr/include -I/usr -I../libavcodec -I../libmythdb -I.. -I../.. -I../libavutil -I. -o el_processor.o el_processor.cpp
gcc -c -pipe -fomit-frame-pointer -O3 -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -maltivec -mabi=altivec -pthread -g -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -fno-math-errno -fno-signed-zeros -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -fPIC -DPIC -w -fPIC -D_REENTRANT -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_AV_CONFIG_H -D_LARGEFILE_SOURCE -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include -I/usr -I../.. -Idvdnav -I../libmythdb -o searching.o dvdnav/searching.c
cd libmythdb/ && make -f Makefile 
make[2]: Entering directory `/builddir/build/BUILD/mythtv-0.22/mythtv-0.22/libs/libmythdb'
sh "/builddir/build/BUILD/mythtv-0.22/mythtv-0.22/version.sh" "/builddir/build/BUILD/mythtv-0.22/mythtv-0.22" ": svn+ssh://svn.mythtv.org/var/lib/svn/trunk/mythtv/version.pro "
g++ -c -pipe -fomit-frame-pointer -O3 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -maltivec -mabi=altivec -g -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -Wno-non-virtual-dtor -funit-at-a-time -D__STDC_CONSTANT_MACROS -pthread -I/usr/include/kde/artsc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -D_REENTRANT -DPIC -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DRUNPREFIX=\"/usr\" -DLIBDIRNAME=\"lib\" -DQT_NO_DEBUG -DQT_SQL_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui -I/usr/include/QtSql -I/usr/include -I/usr/include -I/usr -I. -o mythdbcon.o mythdbcon.cpp
gcc -c -pipe -fomit-frame-pointer -O3 -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -maltivec -mabi=altivec -pthread -g -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -fno-math-errno -fno-signed-zeros -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -fPIC -DPIC -w -fPIC -D_REENTRANT -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_AV_CONFIG_H -D_LARGEFILE_SOURCE -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include -I/usr -I../.. -Idvdnav -I../libmythdb -o settings.o dvdnav/settings.c
gcc -c -pipe -fomit-frame-pointer -O3 -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -maltivec -mabi=altivec -pthread -g -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -fno-math-errno -fno-signed-zeros -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -fPIC -DPIC -w -fPIC -D_REENTRANT -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_AV_CONFIG_H -D_LARGEFILE_SOURCE -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include -I/usr -I../.. -Idvdnav -I../libmythdb -o remap.o dvdnav/remap.c
gcc -c -pipe -fomit-frame-pointer -O3 -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -maltivec -mabi=altivec -pthread -g -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -fno-math-errno -fno-signed-zeros -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -maltivec -fomit-frame-pointer -fPIC -DPIC -w -fPIC -D_REENTRANT -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_AV_CONFIG_H -D_LARGEFILE_SOURCE -I/usr/lib/qt4/mkspecs/linux-g++ -I. -I/usr/include -I/usr -I../.. -Idvdnav -I../libmythdb -o decoder.o dvdnav/vm/decoder.c
In file included from el_processor.cpp:29:
../libavcodec/dsputil.h:183: error: expected identifier before numeric constant
../libavcodec/dsputil.h:183: error: expected ',' or '...' before numeric constant
../libavcodec/dsputil.h:183: error: ISO C++ forbids declaration of 'DECLARE_ALIGNED' with no type
make[2]: Leaving directory `/builddir/build/BUILD/mythtv-0.22/mythtv-0.22/libs/libmythfreesurround'
make[2]: *** [el_processor.o] Error 1
make[1]: *** [sub-libmythfreesurround-make_default] Error 2
make[1]: *** Waiting for unfinished jobs....

Attachments (1)

t6823_fix.diff (386 bytes) - added by Janne Grunau 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Jarod Wilson

Still present with current trunk (r21179), won't have a chance to really dig into it until Monday at the earliest though.

Changed 10 years ago by Janne Grunau

Attachment: t6823_fix.diff added

comment:2 Changed 10 years ago by Janne Grunau

Milestone: unknown0.22
Owner: changed from Isaac Richards to Janne Grunau
Status: newassigned
Version: unknownhead

does the attached patch fix the problem

comment:3 Changed 10 years ago by bander.ajba@…

nope, the attached patch does not fix the problem.

comment:4 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: assignedclosed

(In [21321]) include libavutil/internal.h for DECLARE_ALIGNED on PPC. Fixes #6823

comment:5 Changed 10 years ago by Janne Grunau

(In [21330]) revert [21321], including libavutil/internal.h in a header used in mythtv is a bad idea. Refs #6823

comment:6 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: closednew

comment:7 Changed 10 years ago by Nigel

I can verify the fault (PowerPC with GCC 4.1.2 and -r21349). This fixes it for me:

Index: libs/libmythfreesurround/el_processor.cpp
===================================================================
--- libs/libmythfreesurround/el_processor.cpp   (revision 21349)
+++ libs/libmythfreesurround/el_processor.cpp   (working copy)
@@ -26,6 +26,7 @@
 #include "fftw3.h"
 #else
 extern "C" {
+#include "libavutil/internal.h"   // for DECLARE_ALIGNED
 #include "dsputil.h"
 };
 typedef FFTSample FFTComplexArray[2];

but I am a long way from a complete build (poor little 400 MHz PPC is still building Qt 4.4.1)

comment:8 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: newclosed

(In [21352]) Fix PPC build due to missing DECLARE_ALIGNED in dsputil.h. Fixes #6823

comment:9 Changed 10 years ago by Jarod Wilson

Tardy, but just to confirm, gcc4.4 build went just fine with r21770.

Note: See TracTickets for help on using tickets.