Opened 16 years ago
Closed 16 years ago
#6981 closed defect (fixed)
mythburn.py calls mythreplex with non existent --fix_sync option
| Reported by: | Owned by: | Janne Grunau | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 0.22 |
| Component: | Plugin - MythArchive | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
In my recentish repo (rev 21621) the mythburn.py script in mytharchive calls mythreplex with a non-existent longopt fix_sync.
I'm testing now to see if just removing it is the fix, but no matter the fix, something is broked.
Attachments (3)
Change History (12)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
Removing fix_sync from mythreplex didn't work for me, I got a buffer overflow and the C library aborted. Alas. I'll try and find time tonight to get a stack trace, and to test with the patch now on this bug.
comment:3 Changed 16 years ago by
| Milestone: | unknown → 0.22 |
|---|---|
| Owner: | changed from paulh to Janne Grunau |
| Priority: | minor → blocker |
| Status: | new → assigned |
| Version: | unknown → head |
Looks like many of our local changes where lost during the resync one of which was for MythArchive? but I think several changes where made by ghaushe for the lossless transcoder.
comment:4 Changed 16 years ago by
The patch to mythreplex doesn't do it for me; please find attached the output of trying to run a patched mythreplex after some mytharchive fail.
comment:5 Changed 16 years ago by
It's possible that adding the '-g' (or '--larger_buffer') switch to mythreplex may solve the problem. From the README:
"The -g option can be helpful if you get ringbuffer overflows, it increases the video buffer size. Default is 6MB."
-- Joe Ripley vitaminjoe@…
Changed 16 years ago by
| Attachment: | replex_fix_sync.3.diff added |
|---|
Merged replex_fix_sync.2.diff with updates to mythburn.py, added '-g' option
comment:6 Changed 16 years ago by
Re-adding the '-g' option to replex.c (it was excluded from the getopt_long() call on line 2671 of the patched replex.c). I also doubled the buffer size from the default of 6MB to 12MB by using '-g 12' in mythburn.py.
This solved the problem (for me) that anonymous pointed out in the log attached to this ticket.
I've attached a merged diff that contains robertm's 'replex_fix_sync.2.diff', as well as my own changes to re-enable the '-g' option and add '-g 12' to mythburn.py.
-- Joe Ripley vitaminjoe@…
comment:7 Changed 16 years ago by
OK - I applied this path but it dies as follows:-
Running: mythreplex -g 12 --demux --fix_sync -o /tmp/work/1/stream -v 224 -c 128 "/tmp/work/1/newfile2.mpg" replex version Myth-InternalReading? from (null) Input file length: 3863.12 MB Checking for TS: failed Checking for AVI: failed Checking for PS: confirmed(maybe) Video: aspect ratio: 16:9 size = 720x576 frame rate: 25.000 fps bit rate: 9.00 Mbit/s
vbvbuffer 1835008
Sequence Extension: progressive sequence chroma 4:2:0 size = 720x576 bit rate: 9.00 Mbit/s vbvbuffer 1835008 frame rate: 25.000 starting with video PTS: 0:00:00.500 Aborted
Attached is a patch to restore the --fix_sync option to mythtranscode. I have no MP2 sources so no means of testing it. It probably works, it's based on the original changeset to add the option.