Opened 10 years ago

Closed 9 years ago

#7533 closed patch (fixed)

Retro theme ported to 0.22

Reported by: Chris Candreva <chris@…> Owned by: cpinkham
Priority: trivial Milestone: 0.24
Component: Themes Version: head
Severity: low Keywords:
Cc: chris@… Ticket locked: no

Description

I have ported the Retro theme to 0.22, by taking the new MythCenter?-wide and changing replacing the images with those from Retro.

This is actually then Retro-wide

Change History (12)

comment:1 Changed 10 years ago by Chris Candreva <chris@…>

The system will not let me upload the theme as the file is too big. You can download it from my web site at http://www.westnet.com/~chris/Mythtv/Retro-wide.tar.gz

comment:2 Changed 10 years ago by robertm

Status: newinfoneeded_new

Hi Chris,

Thank you for your interest in Myth Theming, and for your effort so far. For us to consider restoring Retro as an officially supported theme, it needs to be a complete port, not simply copying in the images. I took a look at what you have done so far, which appears to be limited to some changes to the menu and copying in the old Retro images. For retro to be restored, you will need to theme all the myth screens and windows, covered here:

http://www.mythtv.org/wiki/MythUI_Theme_Development

As it is, simply falling back to default is not really a port, at least not one that we can commit to trunk. A port of Retro should contain the old retro layout when possible (in -ui.xml files, noticeably different than those found in default, stored in the actual Retro theme dir), and original layout for new windows that didn't exist before.

I'm leaving this ticket infoneeded for now, you can follow up with whether you want to complete the effort on one of the lists.

Once again, thanks for the effort so far.

comment:3 Changed 10 years ago by robertm

Milestone: 0.22.1unknown
Priority: minortrivial
Severity: mediumlow
Version: 0.22head

comment:4 Changed 10 years ago by Christopher X. Candreva <chris@…>

I believe I have a finished port, available at the same URL:

http://www.westnet.com/~chris/Mythtv/Retro-wide.tar.gz

There is one bug, an extraneous background/alpha image that shows up in videos lists when a video is selected. It looks like an alpha mask for the old frame image, but I can't find where is is referenced. I would greatly appreciate assitance tracking it down.

comment:5 Changed 10 years ago by robertm

Hi Christopher. Thanks for the hard work so far, and I hope that you are enjoying it. Granted, even themes distributed in the code are varying degrees of finished, but please check out the following directory contents:

Retro-wide# ls *.xml

base.xml menu-ui.xml recordings-ui.xml schedule-ui.xml status-ui.xml themeinfo.xml ui.xml video-ui.xml

Graphite# ls *.xml

appear-ui.xml categories.xml dvd-ui.xml menu-ui.xml netflix-ui.xml schedule-ui.xml ui.xml base.xml config-ui.xml gallery-ui.xml movies-ui.xml news-ui.xml status-ui.xml video-ui.xml browser-ui.xml controls-ui.xml game-ui.xml music-ui.xml recordings-ui.xml themeinfo.xml weather-ui.xml

A good guideline for Retro being considered again will probably be something like the "completeness" rules for the theming competition:

http://www.mythtv.org/theming-competition

That more or less breaks down to:

appear-ui.xml dvd-ui.xml menu-ui.xml schedule-ui.xml base.xml config-ui.xml gallery-ui.xml news-ui.xml status-ui.xml video-ui.xml browser-ui.xml controls-ui.xml music-ui.xml recordings-ui.xml themeinfo.xml weather-ui.xml

And (for the one screen that requires it, schdiff) ui.xml

With extra points for more :)

I will try to take a few minutes troo look more closely at your transparency issue over the holiday this weekend.

comment:6 Changed 10 years ago by Christopher X. Candreva <chris@…>

Robert - thank you for looking at this.

I realized after I posted this update last night I hadn't actually uploaded the latest tar file to my web site. It is up there now.

comment:7 Changed 10 years ago by Christopher X. Candreva <chris@…>

I'm going to stop using the word finished, but submitted for your approval is the latest version:

http://www.westnet.com/~chris/Mythtv/Retro-wide.tar.gz

comment:8 Changed 10 years ago by robertm

Status: infoneeded_newnew

comment:9 Changed 9 years ago by danielk

Owner: changed from Isaac Richards to robertm
Status: newassigned

comment:10 Changed 9 years ago by anonymous

The version on my website is updated to support 0.23 and fix some reported issues:

http://www.westnet.com/~chris/Mythtv/Retro-wide.tar.gz

comment:11 Changed 9 years ago by robertm

Milestone: unknown0.25
Owner: changed from robertm to cpinkham

For possible consideration when the theme downloader is done.

comment:12 Changed 9 years ago by cpinkham

Milestone: 0.250.24
Resolution: fixed
Status: assignedclosed

This is on the theme download site, although it is triggering an issue because the theme name (Retro) does not match the theme directory name (Retro-wide), so the theme won't reload after downloading. A change is being made to the ThemeInfo? class and the theme chooser screen to handle this case.

Note: See TracTickets for help on using tickets.