Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7536 closed defect (wontfix)

Mythweb Favorites not Correct for 0.22

Reported by: scottadmi@… Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: 0.22
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The mythweb setting to only show favorite channels is broken for the current release. It refers to the no missing favorites tables. The fix is below for the mythweb file modules/tv/includes/channels.php

    function load_all_channels() {
        global $db;
        global $Channels;
        global $Callsigns;
        $Channels = array();
    // Initialize the query
        if ($_SESSION['guide_favonly'])
            $sql = 'SELECT channel.* FROM channel, channelgroup, channelgroupnames WHERE '
                  ."channelgroupnames.name='Favorites' AND channelgroupnames.grpid = channelgroup.grpid AND "
                  .'channel.chanid = channelgroup.chanid AND';
        else
            $sql = 'SELECT * FROM channel WHERE';

...

Further, a good enhancement would be to add a simple toggle to show just favorites vs. all on the listing page itself to quickly switch info.

Attachments (1)

channels.patch (764 bytes) - added by Steltek 10 years ago.
Patch for channels.php with the reporter's code.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by anonymous

Confirm this bug and that the code provided does fix it.

comment:2 Changed 10 years ago by mythtv at webdeck dot com

For what it's worth, I made this change on my installation and it fixed the problem.

comment:3 Changed 10 years ago by Steltek

Same deal here: Fix works for now. In the long run, a UI to actually select from the channel groups may be needed though.

Changed 10 years ago by Steltek

Attachment: channels.patch added

Patch for channels.php with the reporter's code.

comment:4 Changed 10 years ago by Stuart Auchterlonie

Milestone: 0.220.24

Bumping open 0.22 milestone tickets to 0.24

comment:5 Changed 10 years ago by sphery

#8075 provides a patch to add the link to toggle favorites on the listing page.

Personally, I'd prefer this and #8075 were modified to allow users to select any of their defined channel group.

comment:6 Changed 10 years ago by sphery

Milestone: 0.24unknown
Resolution: wontfix
Status: newclosed

Closing this ticket since #8075 includes an updated patch that makes available all user-defined channel groups (and makes it available through the listings page).

comment:7 Changed 10 years ago by stuartm

Also a dup of #7479

Note: See TracTickets for help on using tickets.