Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 4 years ago

#8121 closed patch (fixed)

Build fixes for windows port

Reported by: Jeff Lu <jll544@…> Owned by: nigel
Priority: minor Milestone: unknown
Component: Ports - Windows Version: head
Severity: medium Keywords: win32
Cc: Ticket locked: yes

Description

Attached are a pair of small patches to build r23640 on Windows:

qtdbus_win.patch: Extend QtDBus check from [23560] to verify that QtDBus lib exists. On Windows, Nokia distributes the headers even though the lib isn't built.

setuid_win.patch: On Windows, disable the MBE --user option from [23521]. MinGW doesn't have pwd.h, and AFAIK there isn't a direct analogue of setuid on Windows anyway.

Attachments (5)

8121-23560_qtdbus_win.patch (585 bytes) - added by Jeff Lu <jll544@…> 4 years ago.
8121-23521_setuid_win.patch (887 bytes) - added by Jeff Lu <jll544@…> 4 years ago.
8121-23521_setuid_win.2.patch (906 bytes) - added by Jeff Lu <jll544@…> 4 years ago.
Updated for [23835]
8121-23575_mythsystem.patch (685 bytes) - added by Jeff Lu <jll544@…> 4 years ago.
8121-23765_fullscreen.patch (967 bytes) - added by Jeff Lu <jll544@…> 4 years ago.

Download all attachments as: .zip

Change History (20)

Changed 4 years ago by Jeff Lu <jll544@…>

Changed 4 years ago by Jeff Lu <jll544@…>

comment:1 Changed 4 years ago by anonymous

Thanks for this! Been driving me mad this one!

Do you know when this is scheduled for inclusion in SVN?

comment:2 Changed 4 years ago by Dibblah

  • Status changed from new to assigned

Changed 4 years ago by Jeff Lu <jll544@…>

Updated for [23835]

Changed 4 years ago by Jeff Lu <jll544@…>

Changed 4 years ago by Jeff Lu <jll544@…>

comment:3 Changed 4 years ago by Jeff Lu <jll544@…>

Two additional patches attached:

mythsystem.patch: Apply result code changes from [23575] to Windows. Returns embedded in Windows code prevented mythtv-setup screens from being drawn.

fullscreen.patch: Change order of operations after [23765] to work around Qt bug. On Windows, Qt does not honor fullscreen mode if setWindowState(Qt::WindowFullScreen?) is called before setWindowFlags(Qt::FramelessWindowHint?). Tested this change on my Fedora and Ubuntu boxes and observed no ill effects for Linux.

comment:4 Changed 4 years ago by jamesjt@…

I'm still having difficulty getting 0.23-fixes to compile. I used .../release-0-23-fixes/.../MythInstaller?.bat to get the latest script, but neither

win32-packager.pl -v -k -b -r HEAD

nor

win32-packager.pl -v -k -b (-l)

will compile at this point.

I manually applied the changes from 8121-23521_setuid_win.2.patch in order to try to get it to compile, and now here's the error I'm stuck with:

make[2]: * [main.o] Error 1
make[2]: Leaving directory `/C/mythtv/mythtv/programs/mythbackend'
make[1]:
* [sub-mythbackend-make_default] Error 2
make[1]: Leaving directory `/C/mythtv/mythtv/programs'
make: * [sub-programs-make_default-ordered] Error 2
EFFECT FAILED (newer -> shell): mtime of file (C:/mythtv/mythtv/programs/mythbackend/mythbackend.exe) should be greater than file (C:/mythtv/mythtv/last_build.txt).

[0] [1272912625]

Could someone point me in the right direction, please?

comment:5 Changed 4 years ago by robertm

  • Ticket locked set

Discussion belongs on mailing lists, please read the ticket howto.

comment:6 Changed 4 years ago by mdean

(In [24479]) Fix fullscreen on MS Windows using patch from Jeff Lu. Refs #8121.

comment:7 Changed 4 years ago by mdean

(In [24480]) Fix myth_system() for MS Windows by using the result-code changes from [23575] in the MS Windows code (the #else following the #ifndef USING_MINGW ). Refs #8121.

comment:8 Changed 4 years ago by mdean

(In [24481]) Remove the pwd.h and grp.h includes in mythbackend/main.cpp after [24030], which moved all the password/group code to mythbackend/main_helpers.cpp. Refs #8121.

comment:9 Changed 4 years ago by mdean

(In [24482]) Compilation fix for MS Windows. Do not allow the --user option on Windows. Refs #8121.

This is an updated version of the patch submitted by Jeff Lu, taking into account changes in [24030]. I can not test the fix on Windows, and since it's not the same patch submitted by Jeff, any breakage is due to me. So if it doesn't work, please let me know with a message to the mailing list.

comment:10 Changed 4 years ago by mdean

I've applied patches for all the (currently) submitted issues, except 8121-23560_qtdbus_win.patch , which I'll leave for someone more knowledgeable than I to review.

comment:11 Changed 4 years ago by janne

(In [24638]) configure: check linking for QtDBus

Fix false positive on windows since the Qt package contains the headers.
Refs #8121

comment:12 Changed 4 years ago by mdean

(In [24640]) Fix fullscreen on MS Windows. Backports [24479] from trunk. Refs #8121.

comment:13 Changed 4 years ago by mdean

(In [24641]) Fix myth_system() for MS Windows. Backports [24480] from trunk. Refs #8121.

comment:14 Changed 4 years ago by mdean

(In [24642]) Compilation fix for MS Windows. Do not allow the --user option on Windows. Backports [24482] (without the updates for changes in trunk) from trunk. Refs #8121.

comment:15 Changed 4 years ago by janne

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [24836]) backports [24638] from trunk

configure: check linking for QtDBus

Fix false positive on windows since the Qt package contains the headers.
Fixes #8121

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.