Opened 8 years ago

Closed 7 years ago

#8363 closed defect (Fixed)

"Play Recording on Frontend" doesn't work if recording "Started Early"

Reported by: ryanr23@… Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: 0.23rc2
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If the scheduled time is used instead of the "actual" time (in case of "Start Early" setting), the recording will not play correctly.

The starttime in the script <mythweb>/modules/tv/tmpl/default/detail.php on line 741 should change from:

... '&starttime='.urlencode($program->starttime) ...

to:

... '&starttime='.urlencode($program->recstarts) ...

Attachments (1)

mythweb-playback-frontend-start-early.diff (794 bytes) - added by jason.chambers@… 8 years ago.
patch referenced in comment:9

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Rob Smith

Resolution: fixed
Status: newclosed

(In [24927]) Fixes #8363, this uses recstarts vs startime to find recordings

comment:2 Changed 8 years ago by anonymous

Resolution: fixed
Status: closednew

comment:3 Changed 8 years ago by Raymond Wagner

Resolution: fixed
Status: newclosed

Need to give an explination, or at least a contact address, if you want something re-opened.

comment:4 Changed 8 years ago by wombo1@…

Hi,

I have just upgraded my Mythbuntu 10.04 system to Trunk.

I have verified that the above changes have been made to the source, but the functionality is still not working.

Below is an extract of what the browser is displaying for that line.

<div class="x-frontends">Play Recording on Frontend:<ul><li><a onclick="watchShow('htpc', '1099', '');">htpc</a><br></ul></div>

comment:5 Changed 8 years ago by robertm

Resolution: fixed
Status: closednew

comment:6 Changed 8 years ago by robertm

Status: newassigned

comment:7 Changed 8 years ago by Rob Smith

Milestone: unknown0.24

comment:8 Changed 8 years ago by Rob Smith

Resolution: fixed
Status: assignedclosed

(In [26122]) Fixes #8363, this fixes the start on frontend functionality

comment:9 Changed 8 years ago by jason.chambers@…

The above fixes are incorrect.

The original description and the changes that went into [24927] had a typo in the time property - they used recstarts rather than recstartts.

This meant it didn't fix the original problem, and actually caused a new problem (comment:4) where no timestamp is included in the call to watchShow().

Then the changes in [26122] in response to comment:4 simply changed back to using starttime. Therefore it reverted to the original behaviour of ignoring any start early value and so mythweb is still unable to start playback of any such recordings.

Attached is a patch (against r27171) to fix this properly.

Changed 8 years ago by jason.chambers@…

patch referenced in comment:9

comment:10 Changed 8 years ago by paulh

Resolution: fixed
Status: closednew

comment:11 Changed 8 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.24unknown
Status: newassigned

comment:12 Changed 7 years ago by Rob Smith

Resolution: Fixed
Status: assignedclosed

Fixed in 6aba7cf

Note: See TracTickets for help on using tickets.