Opened 14 years ago
Closed 13 years ago
#8363 closed defect (Fixed)
"Play Recording on Frontend" doesn't work if recording "Started Early"
Reported by: | Owned by: | Rob Smith | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | Plugin - MythWeb | Version: | 0.23rc2 |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
If the scheduled time is used instead of the "actual" time (in case of "Start Early" setting), the recording will not play correctly.
The starttime in the script <mythweb>/modules/tv/tmpl/default/detail.php on line 741 should change from:
... '&starttime='.urlencode($program->starttime) ...
to:
... '&starttime='.urlencode($program->recstarts) ...
Attachments (1)
Change History (13)
comment:1 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
comment:3 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Need to give an explination, or at least a contact address, if you want something re-opened.
comment:4 Changed 14 years ago by
Hi,
I have just upgraded my Mythbuntu 10.04 system to Trunk.
I have verified that the above changes have been made to the source, but the functionality is still not working.
Below is an extract of what the browser is displaying for that line.
<div class="x-frontends">Play Recording on Frontend:<ul><li><a onclick="watchShow('htpc', '1099', '');">htpc</a><br></ul></div>
comment:5 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
comment:6 Changed 14 years ago by
Status: | new → assigned |
---|
comment:7 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|
comment:8 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:9 Changed 13 years ago by
The above fixes are incorrect.
The original description and the changes that went into [24927] had a typo in the time property - they used recstarts
rather than recstartts
.
This meant it didn't fix the original problem, and actually caused a new problem (comment:4) where no timestamp is included in the call to watchShow()
.
Then the changes in [26122] in response to comment:4 simply changed back to using starttime
. Therefore it reverted to the original behaviour of ignoring any start early value and so mythweb is still unable to start playback of any such recordings.
Attached is a patch (against r27171) to fix this properly.
Changed 13 years ago by
Attachment: | mythweb-playback-frontend-start-early.diff added |
---|
patch referenced in comment:9
comment:10 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
comment:11 Changed 13 years ago by
Milestone: | 0.24 → unknown |
---|---|
Status: | new → assigned |
(In [24927]) Fixes #8363, this uses recstarts vs startime to find recordings