Watch/preview generation segfaults with DVB recordings

[otto at kolsi dot fi]

I started to see segfaults during preview generation some weeks ago and recently noticed that also some recordings are causing segfault when playback is started.

Playback segfault problem can be reproduced with two separate frontends and with the problematic recordings, this problem is 100% reproducible. It looks like problem happens within AvFormatDecoder::ProcessVideoPacket? ().

Backtrace attached.

[robertm]

Otto, a sample would probably help here. If it happens right at the beginning of the file, then relatively small should be okay.

[otto at kolsi dot fi]

Yes, it happens right in the beginning of the file. Last couple of lines in logs (with -v all) are:

2010-05-02 17:30:23.714 detectInterlace(Detect Scan, Interlaced Scan, 25, 576) ->Interlaced Scan
2010-05-02 17:30:23.714 Set video sync frame interval to 40000
2010-05-02 17:30:23.714 Enabled deinterlacing
2010-05-02 17:30:23.714 AFD: avFPS(50) != seqFPS(25)
2010-05-02 17:30:23.725 VBI: Unknown descriptor: 44
2010-05-02 17:30:23.725 VBI: Unknown descriptor: 44
2010-05-02 17:30:23.728 AFD: video timecode 518649448 518638648 5762651 0
Segmentation fault

I've uploaded 10M sample to: ​http://filebin.ca/jhkgbj This shows the problem with e.g. mythavtest.

[Janne Grunau]

(In [24363]) AVFD: cleanup and simplify direct rendering setup

Always use ou get|release_buffer functions and fall back to avcodec's default functions when direct rendering is not possible. Adds safety check and resets directrendering to false if the pixel format changes. Fixes #8410