Opened 10 years ago

Closed 9 years ago

#8494 closed defect (fixed)

Segfault since program info refactor

Reported by: Stuart Auchterlonie Owned by: danielk
Priority: minor Milestone: 0.24
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Going into

Manage Recordings -> Previous Recordings

then deleting info about a previous recording causes a segfault. Backtrace attached.

Stuart

Attachments (2)

program-info-segfault.txt (44.8 KB) - added by Stuart Auchterlonie 10 years ago.
8494-v1.patch (119.4 KB) - added by danielk 10 years ago.
Fixes a number of problems with proglist

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Stuart Auchterlonie

Attachment: program-info-segfault.txt added

Changed 10 years ago by danielk

Attachment: 8494-v1.patch added

Fixes a number of problems with proglist

comment:1 Changed 10 years ago by danielk

There is one "TODO FIXME" in the patch, otherwise it just needs further testing (the fixme as to do with restoring your position in the list after a reload where an item may have been deleted from the list.)

comment:2 Changed 10 years ago by Stuart Auchterlonie

Patch appears to fix the segfault I was seeing

comment:3 Changed 9 years ago by danielk

Resolution: fixed
Status: newclosed

(In [25090]) Fixes #8494. Cleanup of ProgList? code.

I had tried to do a minimal fix of a large memory leak found in this class during the ProgramInfo? refactor, but a high degree of bitrot meant that a bit of reorg was necessary to fix the memory leak safely. This does a full once over of the ProgList? code fixing not just the memory leak but all problems seen. Note: The helper classes in proglist_helpers.{h,cpp} were not cleaned up, only moved to out.

Note: See TracTickets for help on using tickets.