Opened 14 years ago
Closed 14 years ago
#8568 closed enhancement (wontfix)
Vuvuzela filter
Reported by: | JYA | Owned by: | JYA |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - Audio Output | Version: | Unspecified |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Watching the football worlcup? Annoyed with those horns ?
this patch will help.
It is implemented by filtering the frequencies 233, 466, 932 and 1864Hz using a band-stop filter (notch filter)
Was provided the info from: http://www.afterdawn.com/news/article.cfm/2010/06/14/vuvuzela_buzz_ruining_your_world_cup_get_rid_of_it
It is not perfect, but once active, you can finally hear people cheering..
May commit it for convenience, but I feel the bi-quad filters parameters could be improved. If people are willing to tweak a bit, this is done in the file mythtv/libs/libmyth/audiooutpututil.cpp in void AudioOutputUtil::notch_update()
By the way, the methods provided in the above link, don't give IMHO as good results.
How to use it: Go to the settings -> general in the audio section. Activate Advanced Audio and check the Vuvuzela box. Validate all pages to the end.
Now when watching a game, press menu, you'll see an entry "Toggle Vuvuzela Filter"
The vuvuzela filter is disabled by default, and needs to be manually enabled each time
Attachments (7)
Change History (18)
Changed 14 years ago by
Attachment: | vuvuzela.patch added |
---|
comment:1 Changed 14 years ago by
can you pls post your patch for recent 0.23 fixes also? I will try it, but in 0.23 I don't find some files that you patch.
I'm not firm with c++ so I can't do the changes by myself
comment:3 Changed 14 years ago by
New version supports AC3 and DTS audio (and any format for that matter).
Attached version for trunk, you'll need SVN trunk >= r25124, as there were two bugs preventing it to work properly.
Attached version for 0.23-fixes
comment:4 Changed 14 years ago by
trunk 25124 version does not actually apply cleanly.
Hunk 3 of audiooutputbase.cpp fails because the section of code in trunk is
settings.samplerate == source_samplerate && settings.use_passthru == passthru && lneeds_upmix == needs_upmix && lreenc == reenc && lsource_channels == source_channels && lneeds_downmix == needs_downmix;
The patch is looking for
settings.samplerate == source_samplerate && settings.use_passthru == passthru && lneeds_upmix == needs_upmix && lreenc == reenc && lneeds_downmix == needs_downmix;
Changed 14 years ago by
Attachment: | vuvuzela-trunk25124.patch added |
---|
Vuvuzela filter patch for trunk
Changed 14 years ago by
Attachment: | vuvuzela-trunk25124.2.patch added |
---|
Updated to remove weight sum with original signal
comment:6 Changed 14 years ago by
I updated the patch, removing 465 and 235Hz frequencies only. Also made the filter more aggressive. I'm quite pleased with the result now... will give it a rest for now.
Will find why the 0.23-fixes patch doesn't work sometimes with AC3 5.1 audio and update with the new filter paramaters
comment:7 Changed 14 years ago by
Replying to jyavenard:
update trunk patch..
Not sure if that is intended (or desired) but this patch seems to make some white space changes to mythtv/libs/libmythtv/tv_play.cpp which are irrelevant to the changes in this bug.
comment:8 Changed 14 years ago by
It aligns all the strings together, the way they were aligned before... Feel free to revert those changes before applying the patch, who knows, it may compile faster :P
comment:9 Changed 14 years ago by
The new version fixes issues with multi-channels audio and AC3 tracks.
It relies on using 0.23-fixes r25135 and greater as the bug was in the upstream code and got fixed.
Changed 14 years ago by
Attachment: | vuvuzela-trunk25165.patch added |
---|
Updated version for trunk 25165
comment:10 Changed 14 years ago by
Status: | new → infoneeded_new |
---|
Jean-Yves,
Just infoneeding this as I work through tickets since I think you mentioned wanting to close it post-world-cup. Feel free to undo that if I misunderstood.
comment:11 Changed 14 years ago by
Resolution: | → wontfix |
---|---|
Status: | infoneeded_new → closed |
World cup is over, and hopefully so are the vuvuzelas.
Vuvuzela filter