Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 3 years ago

#8595 closed Patch - Feature (Fixed)

Support reading/writing of rating and playcount with ID3 tags

Reported by: stuartm Owned by: stuartm
Priority: trivial Milestone: 0.25
Component: Plugin - MythMusic Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

Primarily this is about maintaining* MythTV metadata, although other apps or hardware can benefit from being able to read this information. MythMusic can also import ratings/play counts from existing POPM tags.

The current implementation inserts the POPM frame with an email address of music@… for identification purposes. There are no immediate plans to allow for another address to be used, I see no justification until we support multiple users in mythmusic. For reading we use the MythTV POPM frame if it exists, otherwise we use the first POPM frame we find. For writing we always use the MythTV frame, since we don't prompt before writing we need to avoid overwriting existing non-myth frames.

The patch is a little rough, but it's limited by the existing architecture.

N.B. The roadmap includes adding file hashing to mythmusic in the same way that is done now for mythvideo, ultimately this will prevent the issue of lost metadata for other tag formats e.g. Flac with Xiph comments.

(*If files are moved or renamed in mythmusic metadata like track ratings, play count and the last play timestamp are lost.)

Attachments (2)

mythmusic_popm.diff (17.9 KB) - added by stuartm 4 years ago.
mythmusic_popm.2.diff (21.5 KB) - added by stuartm 4 years ago.
Updated patch with a few changes, including modtime update

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by stuartm

comment:1 Changed 4 years ago by kja999

Hi,

Is there a way to trigger the update of the metadata to the file other than playing it ?

comment:2 Changed 4 years ago by stuartm

  • Ticket locked set

kja99 can you post your questions to the mythtv-dev mailing list, I'll try to answer them there.

Changed 4 years ago by stuartm

Updated patch with a few changes, including modtime update

comment:3 Changed 4 years ago by stuartm

  • Owner changed from ijr to stuartm
  • Status changed from new to accepted

comment:4 Changed 4 years ago by stuartm

  • Milestone changed from 0.24 to 0.25
  • Priority changed from minor to trivial
  • Severity changed from medium to low
  • Type changed from task to patch

Unfortunately I forgot to commit this before the feature freeze.

comment:5 Changed 4 years ago by stuartm

  • Milestone 0.25 deleted

Milestone 0.25 deleted

comment:6 Changed 3 years ago by stuartm

  • Type changed from patch to Patch - Feature

comment:7 Changed 3 years ago by stuartm

  • Resolution set to Fixed
  • Status changed from accepted to closed

(In [27319]) Allow playcount and rating to be written to and read from ID3 tags meaning they will be preserved even if files are moved. Playcount will be updated each time the file is played. This adds a new setting 'AllowTagWriting?' which defaults to off and which must be enabled for this feature to work since some people would prefer MythTV not to alter their tags in any way. Closes #8595

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.