Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 7 months ago

#8668 closed Patch - Feature (Fixed)

compiling flac on windows (as a requirement for mythmusic)

Reported by: Jonathan Martens <jonathan@…> Owned by:
Priority: minor Milestone: unknown
Component: Ports - Windows Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Although MythMusic also needs libcdaudio (which is a hard on on windows), it also requires flac.

To compile flac to errors during compilation have to be fixed, attached patch does so. I have not been able to tie it in properly into the buildscript, but I thought I'd share it here for others/future reference.

Attachments (2)

flac.patch (1.0 KB) - added by Jonathan Martens <jonathan@…> 4 years ago.
Patch to make flac compile on windows
win32-packager.pl-flac.patch (2.7 KB) - added by Jonathan Martens <jonathan@…> 4 years ago.
Patch to build get flac to compile from the win32 build script

Download all attachments as: .zip

Change History (15)

Changed 4 years ago by Jonathan Martens <jonathan@…>

Patch to make flac compile on windows

comment:1 in reply to: ↑ description Changed 4 years ago by Jonathan Martens <jonathan@…>

Replying to Jonathan Martens <jonathan@…>:

Although MythMusic also needs libcdaudio (which is a hard on on windows), it also requires flac.

To compile flac to errors

Oops, that should have read two errors:

  In file included from stream_decoder.c:57:
  share/alloc.h:41:5: #error
  In file included from stream_decoder.c:57:
  share/alloc.h: In function `safe_malloc_mul_2op_':
  share/alloc.h:120: error: `SIZE_T_MAX' undeclared (first use in this function
  )
  share/alloc.h:120: error: (Each undeclared identifier is reported only once
  share/alloc.h:120: error: for each function it appears in.)
  share/alloc.h: In function `safe_malloc_mul_3op_':
  share/alloc.h:130: error: `SIZE_T_MAX' undeclared (first use in this function
  )
  share/alloc.h: In function `safe_malloc_mul2add_':
  share/alloc.h:143: error: `SIZE_T_MAX' undeclared (first use in this function
  )
  share/alloc.h: In function `safe_realloc_mul_2op_':
  share/alloc.h:196: error: `SIZE_T_MAX' undeclared (first use in this function
  )
main.cpp: In function 'int main(int, char**)':
main.cpp:75: error: 'memcmp' was not declared in this scope

The fixes in this patch are taken from the flac-dev mailinglist (SIZE_T_MAX: http://lists.xiph.org/pipermail/flac-dev/2008-August/002568.html) and the gentoo bug tracker (memcmp: http://bugs.gentoo.org/199579).

comment:2 Changed 4 years ago by robertm

  • Owner changed from nigel to markk
  • Status changed from new to assigned

comment:3 follow-up: Changed 4 years ago by robertm

  • Resolution set to wontfix
  • Status changed from assigned to closed

Jonathan,

I think that getting MythMusic compiling on Windows is an admirable goal, but this patch in isolation can't really be applied to anything. If you'd like to work up the changes to the build script to get and install libcdaudio, and inlike this patch like we do with the Qt stuff, please reopen. Alternately, if there's a later version that incorporates these patches (as the gentoo bug *sort of* seems to indicate, we might be able to get away with using just that. I am closing this "wontfix" for now since it's missing those components, but if you decide to work up a patch, please feel free to reopen and I will test and apply.

comment:4 Changed 4 years ago by Buzz

which flac are you using? The win32-packager used to compile flac 1.2.1 just fine without any mods. If it's a problem with the headers in flac ( which this appears to be), then this should be escalated to the FLAC team.

Changed 4 years ago by Jonathan Martens <jonathan@…>

Patch to build get flac to compile from the win32 build script

comment:5 in reply to: ↑ 3 Changed 4 years ago by Jonathan Martens <jonathan@…>

  • Resolution wontfix deleted
  • Status changed from closed to new

Replying to robertm:

I think that getting MythMusic compiling on Windows is an admirable goal

Thanks!

but this patch in isolation can't really be applied to anything. If you'd like to work up the changes to the build script to get and install libcdaudio, and inlike this patch like we do with the Qt stuff, please reopen.

Still need to do libcdaudio, but here is the flac part, re-opening.

comment:6 Changed 4 years ago by stuarta

  • Milestone changed from unknown to 0.24
  • Version changed from Unspecified to Trunk Head

comment:7 Changed 4 years ago by robertm

  • Milestone changed from 0.24 to 0.25
  • Owner changed from markk to robertm
  • Status changed from new to assigned

This isn't going to happen for .24, I'm not going to make any more such changes to the build script until after the release.

comment:8 Changed 4 years ago by stuartm

  • Milestone 0.25 deleted

Milestone 0.25 deleted

comment:9 Changed 2 years ago by beirdo

  • Milestone changed from 0.25 to unknown

comment:10 Changed 2 years ago by stuartm

  • Type changed from enhancement to Patch - Feature

comment:11 Changed 2 years ago by robertm

  • Owner robertm deleted

comment:12 Changed 2 years ago by wagnerrp

  • Status changed from assigned to new

comment:13 Changed 7 months ago by stuartm

  • Resolution set to Fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.