Opened 15 years ago
Closed 13 years ago
Last modified 13 years ago
#8744 closed patch (fixed)
Mutex protect ChannelScanSM - fix crash/data corruption
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | MythTV - Channel Scanner | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I found this issue while verifying the #8737 fix.
The members in ChannelScanSM are accessed by 3 threads:
1) UI thread 2) ChannelScanSM's own thread 3) DVB thread (via listeners)
The corruption happens because both the ChannelScanSM thread and the DVB thread modifies the following members ts_scanned, extend_transports, currentEncryptionStatus, and currentEncryptionStatusChecked.
will attach a patch that will fix the crash/data corruption, but a proper fix would be to cleanup the code and some fine-grained locking added.
and this issue also exists for 0.23-fixes.
Attachments (1)
Change History (6)
Changed 15 years ago by
| Attachment: | add_mutex_to_ChannelScannerSM.patch added |
|---|
comment:1 Changed 15 years ago by
| Owner: | changed from danielk to Stuart Auchterlonie |
|---|---|
| Status: | new → assigned |
comment:2 Changed 15 years ago by
| Milestone: | unknown → 0.24 |
|---|---|
| Owner: | changed from Stuart Auchterlonie to danielk |
| Priority: | major → minor |
| Status: | assigned → accepted |
comment:3 Changed 15 years ago by
| Milestone: | 0.24 → 0.25 |
|---|
comment:4 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
Fixes #8744. Fixes crash in DVB-x channel scanning.
Branch: master Changeset: 146ee76929fe1b00fe218e9d3364fe22e0f14340
comment:5 Changed 13 years ago by
Fixes #10423. Refs #8744. Fixes A->B,B->A locking issue introduced in [146ee7692]
Branch: master Changeset: f30ffd4b4a9ce16d6c7bcb604e09e07a9e61f3a3
I'll try to look at this before 0.24.