Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#8777 closed enhancement (fixed)

EIT enhancements for DishNet

Reported by: Mark.Buechler@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.24
Component: MythTV - EIT Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: yes

Description

Several patches which separate out DishNet? EIT from Bell and add features available to DishNet? which aren't available to Bell.

Attachments (8)

bell_from_dish.diff (833 bytes) - added by Mark.Buechler@… 9 years ago.
Separate DishNet? fixup from Bell so we can distinguish between the two later.
dish_descriptors1.diff (713 bytes) - added by Mark.Buechler@… 9 years ago.
Define some of the descriptors we'll be using.
dish_descriptors2.diff (21.9 KB) - added by Mark.Buechler@… 9 years ago.
Decode DishNet? descriptors.
dish_descriptors3.diff (4.2 KB) - added by Mark.Buechler@… 9 years ago.
Start using some of the decoded descriptors. Ratings and stars will follow.
dish_descriptors4.diff (7.0 KB) - added by Mark.Buechler@… 9 years ago.
Move ratings from ProgEvent? to DBEvent and add stars to DBEvent.
dish_descriptors5.diff (10.2 KB) - added by Mark.Buechler@… 9 years ago.
Final patch to eitfixup for Bell & Dish.
dish_descriptors6.diff (545 bytes) - added by Mark.Buechler@… 9 years ago.
Set airdate correctly from EIT for Dish/Bell?.
DishEIT.combined.fixed.diff (43.9 KB) - added by robertm 9 years ago.
Updated for trunk, and to compile.

Download all attachments as: .zip

Change History (19)

Changed 9 years ago by Mark.Buechler@…

Attachment: bell_from_dish.diff added

Separate DishNet? fixup from Bell so we can distinguish between the two later.

comment:1 Changed 9 years ago by robertm

Status: newassigned

comment:2 Changed 9 years ago by Stuart Auchterlonie

Status: assignedinfoneeded

No point applying this as is. I'll wait for further patches that (that i assume are coming) that actually make some use of the changes.

Stuart

Changed 9 years ago by Mark.Buechler@…

Attachment: dish_descriptors1.diff added

Define some of the descriptors we'll be using.

Changed 9 years ago by Mark.Buechler@…

Attachment: dish_descriptors2.diff added

Decode DishNet? descriptors.

Changed 9 years ago by Mark.Buechler@…

Attachment: dish_descriptors3.diff added

Start using some of the decoded descriptors. Ratings and stars will follow.

Changed 9 years ago by Mark.Buechler@…

Attachment: dish_descriptors4.diff added

Move ratings from ProgEvent? to DBEvent and add stars to DBEvent.

Changed 9 years ago by Mark.Buechler@…

Attachment: dish_descriptors5.diff added

Final patch to eitfixup for Bell & Dish.

Changed 9 years ago by Mark.Buechler@…

Attachment: dish_descriptors6.diff added

Set airdate correctly from EIT for Dish/Bell?.

comment:3 Changed 9 years ago by Stuart Auchterlonie

Milestone: unknown0.24
Status: infoneededassigned

Changed 9 years ago by robertm

Attachment: DishEIT.combined.fixed.diff added

Updated for trunk, and to compile.

comment:4 Changed 9 years ago by robertm

Status: assignedinfoneeded

Mark,

I applied your patches locally but there were some compile issues (Two instances of DBEventEIT hadn't been updated for the stars argument). I realize that you may have been porting your patches without a trunk system to work on, but is there any chance you can test the updated combined patch that I added? It now compiles properly, and takes into account other changes made in trunk since, but as I do not have access to this EIT info I cannot test.

I also made some slight formatting changes (to avoid an empty set of if brackets, and because QStrings don't need to be initialized to be empty/non-NULL in Qt4). Otherwise this should be as originally written.

comment:5 Changed 9 years ago by Mark.Buechler@…

I'm having several people test this so it may be another week before I get good results.

  • Mark.

comment:6 Changed 9 years ago by Stuart Auchterlonie

(In [26503]) Refs #8777. Descriptor IDs for DishNET EIT.

comment:7 Changed 9 years ago by Stuart Auchterlonie

(In [26504]) Refs #8777. Decode the DishNET descriptors.

comment:8 Changed 9 years ago by Stuart Auchterlonie

(In [26505]) Refs #8777. DishNET EITfixups 1/3

comment:9 Changed 9 years ago by Stuart Auchterlonie

(In [26506]) Refs #8777. DishNET EITFixups 2/3.

comment:10 Changed 9 years ago by Stuart Auchterlonie

Resolution: fixed
Status: infoneededclosed

(In [26507]) Close #8777. DishNET EITfixups 3/3.

comment:11 Changed 7 years ago by stuartm

Ticket locked: set
Note: See TracTickets for help on using tickets.