Opened 8 years ago
Last modified 8 years ago
#8778 accepted Developer Task
RecordingProfile speedups / refactor
| Reported by: | stuartm | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - Recording | Version: | Master Head |
| Severity: | medium | Keywords: | speedup memory leak |
| Cc: | Ticket locked: | no |
Description
Obtaining the profile via RecordingProfile? in TVRec is pretty slow when it doesn't need to be and this impacts channel change times. Populating the 'SelectSetting?' and it's backing ComboBox? alone can take 100ms and this is done twice, once for the signal monitor and once for the actual program.
Attached is an initial suggested change which eliminates a redundant query on the database when loadByType() and loadByGroup() are used (untested atm).
Further improvements can be made by not building the settings object (and therefore the widget) just to return the profile from the database.
Attachments (2)
Change History (8)
Changed 8 years ago by
| Attachment: | recprofile.diff added |
|---|
comment:1 Changed 8 years ago by
| Owner: | changed from danielk to stuartm |
|---|---|
| Status: | new → accepted |
comment:2 Changed 8 years ago by
| Reporter: | changed from anonymous to stuartm |
|---|
Changed 8 years ago by
| Attachment: | valgrind-and-logs.tar.bz2 added |
|---|
comment:3 Changed 8 years ago by
| Keywords: | speedup memory leak added |
|---|---|
| Summary: | RecordingProfile speedups → RecordingProfile speedups / refactor |
Added valgrind logs which show the leaks that the RecordingProfile? class causes.
comment:5 Changed 8 years ago by
(In [ad967599]) Reapply, "Recording profile optimisations (part one)".
comment:6 Changed 8 years ago by
| Type: | patch → Developer Task |
|---|
Valgrind logs and backend log from 2 day long run showing memory leaks in RecordingProfile?