Opened 10 years ago

Last modified 5 months ago

#8778 accepted Developer Task

RecordingProfile speedups / refactor

Reported by: stuartm Owned by: stuartm
Priority: minor Milestone: needs_triage
Component: MythTV - Recording Version: Master Head
Severity: medium Keywords: speedup memory leak
Cc: Ticket locked: no

Description

Obtaining the profile via RecordingProfile? in TVRec is pretty slow when it doesn't need to be and this impacts channel change times. Populating the 'SelectSetting?' and it's backing ComboBox? alone can take 100ms and this is done twice, once for the signal monitor and once for the actual program.

Attached is an initial suggested change which eliminates a redundant query on the database when loadByType() and loadByGroup() are used (untested atm).

Further improvements can be made by not building the settings object (and therefore the widget) just to return the profile from the database.

Attachments (2)

recprofile.diff​ (5.7 KB) - added by anonymous 10 years ago.
valgrind-and-logs.tar.bz2​ (307.9 KB) - added by Stuart Auchterlonie 10 years ago.
Valgrind logs and backend log from 2 day long run showing memory leaks in RecordingProfile?

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by anonymous

Attachment: recprofile.diff​ added

comment:1 Changed 10 years ago by stuartm

Owner: changed from danielk to stuartm
Status: new → accepted

comment:2 Changed 10 years ago by stuartm

Reporter: changed from anonymous to stuartm

Changed 10 years ago by Stuart Auchterlonie

Attachment: valgrind-and-logs.tar.bz2​ added

Valgrind logs and backend log from 2 day long run showing memory leaks in RecordingProfile?

comment:3 Changed 10 years ago by Stuart Auchterlonie

Keywords: speedup memory leak added
Summary: RecordingProfile speedups → RecordingProfile speedups / refactor

Added valgrind logs which show the leaks that the RecordingProfile? class causes.

comment:4 Changed 10 years ago by stuartm

(In [6dd9b7892]) Recording profile optimisations (part one).

comment:5 Changed 10 years ago by stuartm

(In [ad967599]) Reapply, "Recording profile optimisations (part one)".

comment:6 Changed 9 years ago by stuartm

Type: patch → Developer Task

comment:7 Changed 5 months ago by Stuart Auchterlonie

Milestone: unknown → needs_triage
Note: See TracTickets for help on using tickets.