Opened 9 years ago

Closed 9 years ago

#8783 closed enhancement (fixed)

Themes - MythCenter-wide, improvement

Reported by: Johmor Owned by: danielk
Priority: minor Milestone: 0.24
Component: Themes Version: 0.23.1
Severity: low Keywords:
Cc: Ticket locked: no

Description

I have changed a little in how big the textboxes are so the entirely text can be seen.

In version 0.23 change the following:
The map /usr/share/mythtv/themes/MythCenter-wide/

File base.xml
Change baseverywide-xxx to wide: 626
and define baseverywidespinbox
basewide-xxx make allcenter

File schedule-ui.xml
Row 1713: window scheduleeditor
Row 1785: scheduleoptionseditor
Row xxxx: storageoptionseditor
Change many places according to following:
Bottom row raden in big box: 265
Six boxes, left: 340. First box at 305 plus 45 to next.
Use baseverywide-xxx in all boxes.

File welcome-ui.xml
Change box-typ to baseverywidebutton (Row 128)

I attach my changed files (the same files changed from 0.22). I'll hope they will be used at the next update.

Attachments (9)

base.xml (40.3 KB) - added by Johmor 9 years ago.
schedule-ui.xml (71.8 KB) - added by Johmor 9 years ago.
welcome-ui.xml (3.9 KB) - added by Johmor 9 years ago.
base.xml.diff (7.2 KB) - added by Johmor 9 years ago.
schedule-ui.diff (10.5 KB) - added by Johmor 9 years ago.
welcome-ui.diff (580 bytes) - added by Johmor 9 years ago.
diff-MythCenter-wide.upatch (93.4 KB) - added by newbury@… 9 years ago.
MythCenter?-wide field space revisions in diff -u format against svn 25722
diff-MythCenter-wide.2.upatch (93.4 KB) - added by R. Geoffrey Newbury <newbury@…> 9 years ago.
MythCenter?-wide field space revisions in diff -u format against svn 25722
udiff-MythCenter-wide (37.3 KB) - added by R. Geoffrey Newbury <newbury@…> 9 years ago.
Revised spacing-only diff to MythCenter?-wide

Download all attachments as: .zip

Change History (23)

Changed 9 years ago by Johmor

Attachment: base.xml added

Changed 9 years ago by Johmor

Attachment: schedule-ui.xml added

Changed 9 years ago by Johmor

Attachment: welcome-ui.xml added

comment:1 Changed 9 years ago by robertm

Status: newinfoneeded_new

Johmoor,

We will need these files as unified diffs in order to apply changes.

diff -u oldfile newfile

comment:2 Changed 9 years ago by beirdo

Status: infoneeded_newnew

comment:3 Changed 9 years ago by beirdo

Owner: set to beirdo
Status: newassigned

comment:4 Changed 9 years ago by beirdo

Status: assignedinfoneeded

Changed 9 years ago by Johmor

Attachment: base.xml.diff added

Changed 9 years ago by Johmor

Attachment: schedule-ui.diff added

Changed 9 years ago by Johmor

Attachment: welcome-ui.diff added

comment:5 Changed 9 years ago by Johmor

I have now attached *.diff files from the change.

comment:6 Changed 9 years ago by R. Geoffrey Newbury <newbury@…>

Johmor, could you please try applying the 'diff-MythCenter?-wide.upatch' file which I have attached to ticket 8823? I am attempting to do the same thing as you, but I think I have made changes in many more places than you have touched. These should apply if you cd to /usr/local/share/mythtv/themes and then run 'patch -p1 ./MythCenter?-wide diff-MythCenter?-wide.upatch'. At least, it worked for me!

Changed 9 years ago by newbury@…

Attachment: diff-MythCenter-wide.upatch added

MythCenter?-wide field space revisions in diff -u format against svn 25722

Changed 9 years ago by R. Geoffrey Newbury <newbury@…>

MythCenter?-wide field space revisions in diff -u format against svn 25722

comment:7 Changed 9 years ago by R. Geoffrey Newbury <newbury@…>

Ooopps! Forgot to reload this page, and added the diff twice. As before, Johmor please try this diff and report. I think I fixed every listings page. I *think* I stripped all color changes from this diff, but there may be a line or fill color change which I missed removing.

comment:8 Changed 9 years ago by robertm

The above patch incorrectly changes strings (puts a space between words and ellipsis, grammatically incorrect), reverts <template> (correct) to <format> (incorrect), changes shape gradients (correct) to imagetype gradients (incorrect, deprecated), and diffs an .svn dir.

It also changes good XML (<fill color="#000000" alpha="30" />) into bad XML (<fill color="#000000" alpha="30"></fill>) and incorrectly removes a bunch of font definitions in widgets.

It is unappliable in its current state-- To even have a chance of being considered, it really needs to be spacing changes only. In its current state it breaks more than it fixes by far.

comment:9 Changed 9 years ago by R. Geoffrey Newbury <newbury@…>

New version: I have removed all color changes from the new patch. It now has *ONLY* spacing changes. I don't follow your first comment. I cannot find anywhere I changed any strings. I did not change any /fill> endings. These exist in the original.

Changed 9 years ago by R. Geoffrey Newbury <newbury@…>

Attachment: udiff-MythCenter-wide added

Revised spacing-only diff to MythCenter?-wide

comment:10 Changed 9 years ago by robertm

Status: infoneededassigned

comment:11 Changed 9 years ago by robertm

Owner: changed from beirdo to danielk

comment:12 Changed 9 years ago by danielk

Milestone: unknown0.24

comment:13 Changed 9 years ago by danielk

(In [26268]) Refs #8783. Applied the recordings-ui.xml portion of the patch. I did not apply the changes to the recording list items as 1/ the used odd dimensions which look different at 1920x1080 and 1280x720 2/ they caused the little status balls to be rendered in the same location as the text (possibly also the playlist checkmarks, but did not check those).

comment:14 Changed 9 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [26270]) Fixes #8783. Applies remainder of MythCenter?-wide spacing changes patch (minus 1 font color change).

Note: See TracTickets for help on using tickets.