[PATCH] mythmusic directory permissions

[lvr@…]

When mythmusic creates the sub-directories of the path for a new music file then umask is set to 022 - clearing the 'group write' and 'other write' bits. This can create problems when the base directory is on a mounted share and the creator is not the owner of the share but has write permission by means of group membership; for instance when the directory is shared over NFS or Samba and the permissions are drwsrwsr-t, i.e. a 'drop box'. In this case when the file is created the missing group write permission on the containing directory causes the open to fail.

The attached patch changes umask to 002, permitting 'group write' in the created directories.

[lvr@…]

directory permissions

[paulh]

If you remove the call to umask() does it then do the right thing for you? I believe Qt will try to create the directory with the same permissions as the parent which is what we want in most cases.

[Lawrence Rust <lvr@…>]

Apologies for the delay in replying - been away over the holidays and now catching up with the backlog. Happy New Year.

If the call to umask() is removed then the directory is created OK, given that the parent process' umask is set correctly. At least in this case the user is back in control and can set umask from the command line or a script.

[Github]

MythMusic: relax the write permissions on directories created by the ripper.

Fixes #9112.

Branch: master Changeset: 63bd364a2324062094dcacc2fd878244a4e28e13