Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9288 closed Bug Report (Fixed)

Change 24895- the toLower is the wrong place

Reported by: cpw@… Owned by: beirdo
Priority: trivial Milestone: 0.24.1
Component: Plugin - MythGallery Version: 0.24
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi
Myth 0.24 broke mythgallery video playing for me. All my files are (unfortunately) in upper case: *.MOV mostly. The Changeset 24895 adding in mp4 and cleaning up the upper/lower stuff in the filter does one thing slightly wrong. The change does this:

        if ((*it).toLower().contains(fi.suffix())) 

However, you actually meant to toLower the file suffix, so it matches the filter contents:

        if ((*it).contains(fi.suffix().toLower()))

I have compiled this change locally and confirm it works.

Christian

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by beirdo

  • Milestone changed from unknown to 0.24.1
  • Priority changed from major to trivial
  • Status changed from new to assigned

comment:2 Changed 3 years ago by beirdo

Committed in 641d6e65 for master, fe9d48e5 for fixes/0.24

comment:3 Changed 3 years ago by beirdo

  • Resolution set to Fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.