Opened 9 years ago

Closed 8 years ago

#9362 closed Patch - Feature (fixed)

[PATCH] Mythmusic: CD playing & ripping for Windows

Reported by: lvr@… Owned by: stuartm
Priority: minor Milestone: 0.25
Component: Plugin - MythMusic Version: 0.24-fixes
Severity: medium Keywords: mythmusic libcdio cd
Cc: Ticket locked: no

Description

This series of patches enables MythMusic to play and rip CDs on Windows. It also converts cddecoder.cpp from the obsolete libcdaudio to the newer, portable libcdio and adds code to replace libcdaudio CDDB lookups.

  • 10-mythmusic-cdio-configure.diff: Changes to mythplugins/configure. By default the new code is not built unless --enable-cdio is passed to configure
  • 30-mythmusic-cdio-pro.diff: Changes to include the new decoder when passed the cdio build option
  • 40-mythmusic-cdio-cddecoder.diff: The new cddecoder and patches to the old one for compatibility
  • 50-mythmusic-cdio-cddb.diff: The new CDDB lookup
  • 60-mythmusic-cdio-cdrip.diff: Use libcdio for ripping
  • 70-mythmusic-cdio-main.diff: Includes the new cdio code when configured.
  • 99-mythmusic-cdio-playbackbox.diff: Patches submitted on ticket #9258 but are included for completeness because they're needed for this feature to work correctly

Attachments (7)

10-mythmusic-cdio-configure.diff (2.0 KB) - added by lvr@… 9 years ago.
30-mythmusic-cdio-pro.diff (1.5 KB) - added by anonymous 9 years ago.
40-mythmusic-cdio-cddecoder.diff (31.3 KB) - added by anonymous 9 years ago.
50-mythmusic-cdio-cddb.diff (21.6 KB) - added by anonymous 9 years ago.
60-mythmusic-cdio-cdrip.diff (5.6 KB) - added by anonymous 9 years ago.
70-mythmusic-cdio-main.diff (3.4 KB) - added by anonymous 9 years ago.
99-mythmusic-cdio-playbackbox.diff (4.9 KB) - added by anonymous 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by lvr@…

Changed 9 years ago by anonymous

Attachment: 30-mythmusic-cdio-pro.diff added

Changed 9 years ago by anonymous

Changed 9 years ago by anonymous

Attachment: 50-mythmusic-cdio-cddb.diff added

Changed 9 years ago by anonymous

Changed 9 years ago by anonymous

Attachment: 70-mythmusic-cdio-main.diff added

Changed 9 years ago by anonymous

comment:1 Changed 9 years ago by Kenni Lund [kenni a kelu dot dk]

Status: newassigned

comment:2 Changed 8 years ago by paulh

Owner: changed from paulh to stuartm

Stuart says he will look at this one.

comment:3 Changed 8 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: assignedclosed

MythMusic: Use the portable libcdio for reading CDs

This patch enables MythMusic to play and rip CDs using libcdio on all platforms and also adds code to replace libcdaudio CDDB lookups.

NOTE: This removes libcdaudio and the CDDA Paranoia libraries as dependencies and adds libcdio as an optional dependency (if it's missing you wont be able to play or rip CDs). Closes #9362, #7857.

NOTE: It seems the freedb.freedb.org server is currently down so I had to do some of the testing using the musicbrainz mirror. It was working fine yesterday so I've left it hardcoded to the freedb server for now.

Branch: master Changeset: c121c3acd74a3cabfb37e22bc88ef24552e1e2e7

Note: See TracTickets for help on using tickets.